Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

코드 성능 최적화 (번들 최적화, 코드스플리팅, 트리쉐이킹) #182

Merged
merged 4 commits into from
Oct 17, 2023
Merged

코드 성능 최적화 (번들 최적화, 코드스플리팅, 트리쉐이킹) #182

merged 4 commits into from
Oct 17, 2023

Conversation

ksmfou98
Copy link
Contributor

📑 작업리스트

코드 성능 최적화 (번들 최적화, 코드스플리팅, 트리쉐이킹)

📘 리뷰노트

  • 참고 사항1

@vercel
Copy link

vercel bot commented Oct 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jurumarble ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 2:37am
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 2:37am

@ksmfou98
Copy link
Contributor Author

ksmfou98 commented Oct 16, 2023 •
edited
Loading

[메인 코드 스플리팅]

image

@ksmfou98
Copy link
Contributor Author

ksmfou98 commented Oct 16, 2023 •
edited
Loading

[1차 개선]

image

@Leejha
Copy link
Member

Leejha commented Oct 16, 2023

저 first load js 값이 줄어드는 건가요?

@ksmfou98
Copy link
Contributor Author

[2차 개선] - 빨간색 다 사라짐

image

@ksmfou98
Copy link
Contributor Author

ksmfou98 commented Oct 16, 2023 •
edited
Loading

[3차 개선] - 우선 급한대로 이정도로

image

@ksmfou98
Copy link
Contributor Author

어푸해주세용~

Leejha
Leejha approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@Leejha Leejha left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최적화 배워갑니다!
develop 브랜치에서 작업중인게 있어서 머지는 좀만 기다렸다 해주세요

@ksmfou98 ksmfou98 merged commit c262f2d into develop Oct 17, 2023
4 checks passed
@ksmfou98 ksmfou98 deleted the feature/feat-optimize-code branch October 17, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leejha Leejha Leejha approved these changes

@leejiho9898 leejiho9898 Awaiting requested review from leejiho9898

Assignees

@ksmfou98 ksmfou98

Labels
dependencies JURUMARBLE PACKAGES 🙏리뷰해주세요
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksmfou98 @Leejha