[JR-879] 로그인 되어있지 않을시 나타나는 모달 구현 #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Leejha
force-pushed
the
JR-879-qa-process-non-login
branch
from
c2940d5
to
8315f42
Compare
leejiho9898
approved these changes
Oct 18, 2023
| @@ -59,7 +65,7 @@ const DrinkInfoContainer = () => { | |||
| </PreviousButton> | |||
| } | |||
| rightButton={ | |||
| <PreviousButton onClick={() => router.back()}> | |||
| <PreviousButton onClick={() => router.push(Path.SEARCH_PAGE)}> | |||
There was a problem hiding this comment.
안드로이드 뒤로가기키 클릭과 privious button 동작이 달라질텐데 의도된 동작이 맞을까요?
There was a problem hiding this comment.
아 그런데 저게 검색 아이콘이더라고요
이전 버튼은 왼쪽에 있습니다!
Leejha
force-pushed
the
JR-879-qa-process-non-login
branch
from
1d5d95e
to
1940d89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 작업리스트
📘 리뷰노트