This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
HTTP over UDP friendly #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ps. Not sure how this fits with Teepee & thanks for your work on the lib. |
| @@ -202,7 +202,6 @@ fn test_read_request_line() { | |||
| /// An HTTP request sent to the server. | |||
| pub struct Request { | |||
| /// The originating IP address of the request. | |||
| pub remote_addr: Option<SocketAddr>, | |||
There was a problem hiding this comment.
Is the removal of remote_addr intentional?
There was a problem hiding this comment.
ah yes, I removed it to get my code working. The current way to access the remote_addr isn't really generic:
buffer.stream.wrapped.peer_name().ok()
Not sure how remote_addr is being used on the Request but perhaps it could be passed separately to fn load?
There was a problem hiding this comment.
actually I never realised it was an Option, I guess there is a smarter way for me to handle this... I'll take another look.
Also remove remote_addr which doesn't exist on UdpSockets
very useful!
Also keep memstream for tests
|
Rebased |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a library in Rust for use with the UPnP discovery protocol SSDP. This uses HTTP-ish over UDP.
No longer requires a specific TcpStream in the BufferedStream so it's possible to use your MemReaderFakeStream.
FYI - these changes are working here: https://github.com/davbo/rust-ssdp/blob/master/src/lib.rs#L36