Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always save last position before jump #86

Merged
merged 1 commit into from
May 20, 2024

Conversation

phanen
Copy link
Contributor

@phanen phanen commented May 19, 2024

Checklist

  • Used only camelCase variable names.
  • If functionality is added or modified, also made respective changes to the
    README.md (the .txt file is auto-generated and does not need to be modified).
  • Used conventional commits keywords.

@chrisgrieser
Copy link
Owner

chrisgrieser commented May 19, 2024

Thanks for the PR.

I am wondering, is there a reason to not just always save the previous position in the jump list? Because I can see just adding this behavior without a setting.

@phanen
Copy link
Contributor Author

phanen commented May 20, 2024

To be consist with the default behavior of vim's builtin textobjects, I also think it's more reasonable to always save the position.

@phanen phanen force-pushed the feat/saveJumplist branch 2 times, most recently from d64cbee to 9fb18fe Compare May 20, 2024 03:09
@phanen phanen changed the title feat: option to save last position before jump fix: always save last position before jump May 20, 2024
@chrisgrieser
Copy link
Owner

All right. One Last thing, could you add a comment for the purpose of the m`? It might be a bit looking at it later on otherwise

@phanen
Copy link
Contributor Author

phanen commented May 20, 2024

Added.

@chrisgrieser
Copy link
Owner

Thank you, and thanks very much for the PR itself!

@chrisgrieser chrisgrieser merged commit f62592a into chrisgrieser:main May 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants