Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regexp with query params fail without trailing slash after host #67

Open
gerard76 opened this issue Nov 1, 2022 · 0 comments
Open

Regexp with query params fail without trailing slash after host #67

gerard76 opened this issue Nov 1, 2022 · 0 comments

Comments

@gerard76
Copy link

gerard76 commented Nov 1, 2022

require 'fakeweb'
FakeWeb.allow_net_connect = false

reg = /http:\/\/a\.com\?a=1/
uri=URI("http://a.com?a=1")
FakeWeb.register_uri(:get, reg, body: 'ok')
Net::HTTP.get(uri)

results in a FakeWeb::NetConnectNotAllowedError (Real HTTP connections are disabled. Unregistered request: GET http://a.com/?a=1)

But uri.to_s.match reg gives a match

Registering the same url without regular expression also works

FakeWeb.clean_registry
uri=URI("http://a.com?a=1")
FakeWeb.register_uri(:get, uri.to_s, body: 'ok')
Net::HTTP.get(uri)

With a regular expression you need to add the trailing slash after the hostname to get a good result

FakeWeb.clean_registry
reg = /http:\/\/a\.com\/\?a=1/
uri=URI("http://a.com?a=1")
FakeWeb.register_uri(:get, reg, body: 'ok')
Net::HTTP.get(uri)

Seems inconsistent to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant