Skip to content

Commit

Permalink
chore(deps): update dependency fluentassertions to v8
Browse files Browse the repository at this point in the history
  • Loading branch information
@renovate
renovate[bot] authored Jan 14, 2025
1 parent c9f7e2d commit 4e0b197
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Refitter.SourceGenerator.Tests/Refitter.SourceGenerator.Tests.csproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Http.Resilience" Version="9.0.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
<PackageReference Include="FluentAssertions" Version="7.0.0" />
<PackageReference Include="FluentAssertions" Version="8.0.0" />
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.0.1">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
Expand Down

7 comments on commit 4e0b197

@Fargekritt
Copy link
Contributor

@Fargekritt Fargekritt commented on 4e0b197 Jan 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christianhelle Just want to point out the FluentAssertions has changed license on ver 8.x.x, not sure on the impact this has on this project.
fluentassertions/fluentassertions#2943

Edit: its no longer FOSS, but instead agressive license fees for commercial use

@Matthew-Davey
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for commercial use

Is refitter a commercial project?

@ildoc
Copy link

@ildoc ildoc commented on 4e0b197 Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is refitter a commercial project?

it is used in commercial projects

@Fargekritt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If i read the license correctly which i likely didnt, commercial projects using a product that uses FA v8 during testing also needs a license

@christianhelle
Copy link
Owner

@christianhelle christianhelle commented on 4e0b197 Jan 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fargekritt thanks for bringing this up

@Matthew-Davey No, Refitter is not a commercial project and will most likely never be. I mean who would pay for something so simple anyway 😄 But I guess a lot of FOSS projects started that way so one can never know what happens in the future

I was a bit late to the FluentAssertions drama, but I think I will just revert the package update and keep it at v7.

I'm not smart enough to understand how unit tests could ever be a commercial project since you don't ship the tests, you ship the product

@christianhelle
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted back to v7 -> #588

@christianhelle
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FluentAssertions will remain on version 7.x

Please sign in to comment.