Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

A bug in the benchmark program... #47

Open
JacksonGL opened this issue May 3, 2017 · 0 comments
Open

A bug in the benchmark program... #47

JacksonGL opened this issue May 3, 2017 · 0 comments

Comments

@JacksonGL
Copy link

I know this is a performance benchmark. But there is probably a bug here.

if (sixbits[3] >= 0x40) {
	decode64.length -= 1;  // no side effect
	if (sixbits[2] >= 0x40) {
		decode64.length -= 1; // no side effect
	}
}

decode64 holds a primitive string value. Decreasing its length property has no side effect: it won't throw away the last character.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant