PoC - Use dynamic client in Chains services #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Use dynamic client to access Tekton CRD in Chains services (formatting, signing and uploading). This allows Chains services (excluding the controller logic) to work with the CRDs while avoiding strong dependencies.
Note: This is just an initial PoC PR for the refactor focusing on the taskrun level of the formatting service of the slsa v2 brand. If we decide to go down this route, more PRs will come.
Some high level steps:
TektonObject
: RefactorTektonObject
so that it is based on unstructured object and has some operations to access the commonly used attributes of the Tekton objects (i.e. status.results, status.spec, status.startTime completeionTime etc.)Sign
- entrypoint to Chains core services:tektonObj
will be based on unstructured type. As such, some operations might not be accessible anymore.Review guide
TODO [0-9]
to check the corresponding places in the code for the steps mentioned abovereimpl
are the refactor of its corresponding original implementation.Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes