Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content is rendered into wrong element in tests #943

Open
dagroe opened this issue Jan 10, 2025 · 1 comment
Open

Content is rendered into wrong element in tests #943

dagroe opened this issue Jan 10, 2025 · 1 comment

Comments

@dagroe
Copy link

dagroe commented Jan 10, 2025

In testing environment the content of dropdowns is rendered into config['APP']?.rootElement (which is ENV.APP.rootElement = '#ember-testing'; by default) instead of the defined destination or the default ember-basic-dropdown-wormhole.

In our acceptance tests this leads to wrongly placed content in tests. Should config['APP']?.rootElement be considered a fallback if neither destination nor ember-basic-dropdown-wormhole are available?

@mkszepp
Copy link
Collaborator

mkszepp commented Jan 14, 2025

@dagroe thanks for reporting. I thinks its possible to change... Would you like to make a PR for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants