[fix] add live region root check to alert component (#55)

* [fix] add liveRegionRoots to prevent unnecessary usage of ReactDOM createRoot method * Publish - @ciceksepeti/cui-accordion@0.0.15 - @ciceksepeti/cui-alert-dialog@0.1.5 - @ciceksepeti/cui-alert@0.11.5 - @ciceksepeti/cui-checkbox@0.0.19 - @ciceksepeti/cui@0.11.7 - @ciceksepeti/cui-dialog@0.11.5 - @ciceksepeti/cui-focus-trap@0.1.5 - @ciceksepeti/cui-hooks@0.11.5 - @ciceksepeti/cui-listbox@0.0.20 - @ciceksepeti/cui-popover@0.5.0 - @ciceksepeti/cui-portal@0.1.5 - @ciceksepeti/cui-radio-group@0.0.16 - @ciceksepeti/cui-skip-nav@0.1.5 - @ciceksepeti/cui-tabs@0.0.16 - @ciceksepeti/cui-utils@0.11.5 - @ciceksepeti/cui-visually-hidden@0.1.5 * [chore] remove unnecessary blank lines --------- Co-authored-by: Emir Akar <emir.akar@csadmins-MacBook-Pro.local>
ciceksepetitech · Feb 13, 2024 · d0b9470 · d0b9470
1 parent a4fc6ca
commit d0b9470
Show file tree

Hide file tree

Showing 34 changed files with 316 additions and 85 deletions.
diff --git a/packages/accordion/CHANGELOG.md b/packages/accordion/CHANGELOG.md
@@ -3,6 +3,18 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.0.15](https://github.com/ciceksepetitech/cactus-ui/compare/@ciceksepeti/cui-accordion@0.0.11...@ciceksepeti/cui-accordion@0.0.15) (2024-02-13)
+
+
+
+## 0.0.26 (2024-02-12)
+
+**Note:** Version bump only for package @ciceksepeti/cui-accordion
+
+
+
+
+
 ## [0.0.14](https://github.com/ciceksepetitech/cactus-ui/compare/@ciceksepeti/cui-accordion@0.0.11...@ciceksepeti/cui-accordion@0.0.14) (2024-02-12)
 
 **Note:** Version bump only for package @ciceksepeti/cui-accordion

diff --git a/packages/accordion/package.json b/packages/accordion/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ciceksepeti/cui-accordion",
-  "version": "0.0.14",
+  "version": "0.0.15",
   "description": "ÇiçekSepeti Accordion Component",
   "author": "ciceksepeti",
   "main": "dist/src/index.js",
@@ -20,8 +20,8 @@
     "url": "git+https://github.com/ciceksepetitech/cactus-ui.git"
   },
   "dependencies": {
-    "@ciceksepeti/cui-hooks": "0.11.4",
-    "@ciceksepeti/cui-utils": "0.11.4"
+    "@ciceksepeti/cui-hooks": "0.11.5",
+    "@ciceksepeti/cui-utils": "0.11.5"
   },
   "peerDependencies": {
     "react": ">=16",

diff --git a/packages/alert-dialog/CHANGELOG.md b/packages/alert-dialog/CHANGELOG.md
@@ -3,6 +3,18 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.1.5](https://github.com/ciceksepetitech/cactus-ui/compare/@ciceksepeti/cui-alert-dialog@0.1.1...@ciceksepeti/cui-alert-dialog@0.1.5) (2024-02-13)
+
+
+
+## 0.0.26 (2024-02-12)
+
+**Note:** Version bump only for package @ciceksepeti/cui-alert-dialog
+
+
+
+
+
 ## [0.1.4](https://github.com/ciceksepetitech/cactus-ui/compare/@ciceksepeti/cui-alert-dialog@0.1.1...@ciceksepeti/cui-alert-dialog@0.1.4) (2024-02-12)
 
 **Note:** Version bump only for package @ciceksepeti/cui-alert-dialog

diff --git a/packages/alert-dialog/package.json b/packages/alert-dialog/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ciceksepeti/cui-alert-dialog",
-  "version": "0.1.4",
+  "version": "0.1.5",
   "description": "ÇiçekSepeti Alert Dialog Component",
   "author": "ciceksepeti",
   "sideEffects": [
@@ -24,9 +24,9 @@
     "url": "git+https://github.com/ciceksepetitech/cactus-ui.git"
   },
   "dependencies": {
-    "@ciceksepeti/cui-dialog": "0.11.4",
-    "@ciceksepeti/cui-hooks": "0.11.4",
-    "@ciceksepeti/cui-utils": "0.11.4"
+    "@ciceksepeti/cui-dialog": "0.11.5",
+    "@ciceksepeti/cui-hooks": "0.11.5",
+    "@ciceksepeti/cui-utils": "0.11.5"
   },
   "peerDependencies": {
     "react": ">=16",

diff --git a/packages/alert/CHANGELOG.md b/packages/alert/CHANGELOG.md
@@ -3,6 +3,18 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.11.5](https://github.com/ciceksepetitech/cactus-ui/compare/@ciceksepeti/cui-alert@0.11.1...@ciceksepeti/cui-alert@0.11.5) (2024-02-13)
+
+
+
+## 0.0.26 (2024-02-12)
+
+**Note:** Version bump only for package @ciceksepeti/cui-alert
+
+
+
+
+
 ## [0.11.4](https://github.com/ciceksepetitech/cactus-ui/compare/@ciceksepeti/cui-alert@0.11.1...@ciceksepeti/cui-alert@0.11.4) (2024-02-12)
 
 **Note:** Version bump only for package @ciceksepeti/cui-alert

diff --git a/packages/alert/package.json b/packages/alert/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ciceksepeti/cui-alert",
-  "version": "0.11.4",
+  "version": "0.11.5",
   "description": "ÇiçekSepeti Accessible Alert Component",
   "author": "ciceksepeti",
   "main": "dist/src/index.js",
@@ -20,9 +20,9 @@
     "url": "git+https://github.com/ciceksepetitech/cactus-ui.git"
   },
   "dependencies": {
-    "@ciceksepeti/cui-hooks": "0.11.4",
-    "@ciceksepeti/cui-utils": "0.11.4",
-    "@ciceksepeti/cui-visually-hidden": "0.1.4"
+    "@ciceksepeti/cui-hooks": "0.11.5",
+    "@ciceksepeti/cui-utils": "0.11.5",
+    "@ciceksepeti/cui-visually-hidden": "0.1.5"
   },
   "peerDependencies": {
     "react": ">=16",

diff --git a/packages/alert/src/index.tsx b/packages/alert/src/index.tsx
@@ -48,6 +48,15 @@ const liveRegionContainers: LiveRegionElementTypes = {
   assertive: null
 };
 
+/**
+ * holds references to created live roots
+ */
+const liveRegionRoots: LiveRegionRoots = {
+  off: null,
+  polite: null,
+  assertive: null
+};
+
 /**
  * creates functions for a created alert
  * @param liveRegionType
@@ -108,7 +117,13 @@ const renderAlertsToRegions = () => {
     const regionElements = liveRegionContainerElements[liveRegionType];
 
     if (container) {
-      const root = ReactDOM.createRoot(container as Element);
+      let root = liveRegionRoots[liveRegionType];
+
+      if (!root) {
+        const _root = ReactDOM.createRoot(container as Element);
+        liveRegionRoots[liveRegionType] = _root;
+        root = _root;
+      }
 
       root.render(
         <VisuallyHidden as="div">
@@ -198,6 +213,10 @@ type LiveRegionElementTypes<T extends HTMLElement = HTMLDivElement> = {
   [key in LiveRegionType]: T | null;
 };
 
+type LiveRegionRoots = {
+  [key in LiveRegionType]: ReactDOM.Root | null;
+};
+
 type LiveRegionKeys = {
   [key in LiveRegionType]: number;
 };

diff --git a/packages/checkbox/CHANGELOG.md b/packages/checkbox/CHANGELOG.md
@@ -3,6 +3,21 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.0.19](https://github.com/ciceksepetitech/cactus-ui/compare/@ciceksepeti/cui-checkbox@0.0.13...@ciceksepeti/cui-checkbox@0.0.19) (2024-02-13)
+
+
+
+## 0.0.26 (2024-02-12)
+
+
+### Bug Fixes
+
+* listbox input search rerender trigger issue fix ([#47](https://github.com/ciceksepetitech/cactus-ui/issues/47)) ([d426f09](https://github.com/ciceksepetitech/cactus-ui/commit/d426f0918db2ef14614ed144b4713e2f80fa73c4))
+
+
+
+
+
 ## [0.0.18](https://github.com/ciceksepetitech/cactus-ui/compare/@ciceksepeti/cui-checkbox@0.0.13...@ciceksepeti/cui-checkbox@0.0.18) (2024-02-12)
 
 

diff --git a/packages/checkbox/package.json b/packages/checkbox/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ciceksepeti/cui-checkbox",
-  "version": "0.0.18",
+  "version": "0.0.19",
   "description": "ÇiçekSepeti Checkbox Component",
   "author": "ciceksepeti",
   "main": "dist/src/index.js",
@@ -24,8 +24,8 @@
     "url": "git+https://github.com/ciceksepetitech/cactus-ui.git"
   },
   "dependencies": {
-    "@ciceksepeti/cui-hooks": "0.11.4",
-    "@ciceksepeti/cui-utils": "0.11.4"
+    "@ciceksepeti/cui-hooks": "0.11.5",
+    "@ciceksepeti/cui-utils": "0.11.5"
   },
   "peerDependencies": {
     "react": ">=16",

diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md
@@ -3,6 +3,21 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.11.7](https://github.com/ciceksepetitech/cactus-ui/compare/@ciceksepeti/cui@0.11.1...@ciceksepeti/cui@0.11.7) (2024-02-13)
+
+
+
+## 0.0.26 (2024-02-12)
+
+
+### Bug Fixes
+
+* listbox input search rerender trigger issue fix ([#47](https://github.com/ciceksepetitech/cactus-ui/issues/47)) ([d426f09](https://github.com/ciceksepetitech/cactus-ui/commit/d426f0918db2ef14614ed144b4713e2f80fa73c4))
+
+
+
+
+
 ## [0.11.6](https://github.com/ciceksepetitech/cactus-ui/compare/@ciceksepeti/cui@0.11.1...@ciceksepeti/cui@0.11.6) (2024-02-12)
 
 

diff --git a/packages/components/package.json b/packages/components/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ciceksepeti/cui",
-  "version": "0.11.6",
+  "version": "0.11.7",
   "description": "ÇiçekSepeti Cactus UI All Packages",
   "author": "cs",
   "main": "dist/src/index.js",
@@ -23,21 +23,21 @@
     "styles.css"
   ],
   "dependencies": {
-    "@ciceksepeti/cui-accordion": "0.0.14",
-    "@ciceksepeti/cui-alert": "0.11.4",
-    "@ciceksepeti/cui-alert-dialog": "0.1.4",
-    "@ciceksepeti/cui-checkbox": "0.0.18",
-    "@ciceksepeti/cui-dialog": "0.11.4",
-    "@ciceksepeti/cui-focus-trap": "0.1.4",
-    "@ciceksepeti/cui-hooks": "0.11.4",
+    "@ciceksepeti/cui-accordion": "0.0.15",
+    "@ciceksepeti/cui-alert": "0.11.5",
+    "@ciceksepeti/cui-alert-dialog": "0.1.5",
+    "@ciceksepeti/cui-checkbox": "0.0.19",
+    "@ciceksepeti/cui-dialog": "0.11.5",
+    "@ciceksepeti/cui-focus-trap": "0.1.5",
+    "@ciceksepeti/cui-hooks": "0.11.5",
     "@ciceksepeti/cui-listbox": "0.0.10",
-    "@ciceksepeti/cui-popover": "0.4.0",
-    "@ciceksepeti/cui-portal": "0.1.4",
-    "@ciceksepeti/cui-radio-group": "0.0.15",
-    "@ciceksepeti/cui-skip-nav": "0.1.4",
-    "@ciceksepeti/cui-tabs": "0.0.15",
-    "@ciceksepeti/cui-utils": "0.11.4",
-    "@ciceksepeti/cui-visually-hidden": "0.1.4"
+    "@ciceksepeti/cui-popover": "0.5.0",
+    "@ciceksepeti/cui-portal": "0.1.5",
+    "@ciceksepeti/cui-radio-group": "0.0.16",
+    "@ciceksepeti/cui-skip-nav": "0.1.5",
+    "@ciceksepeti/cui-tabs": "0.0.16",
+    "@ciceksepeti/cui-utils": "0.11.5",
+    "@ciceksepeti/cui-visually-hidden": "0.1.5"
   },
   "devDependencies": {
     "gulp": "^4.0.2",

diff --git a/packages/dialog/CHANGELOG.md b/packages/dialog/CHANGELOG.md
@@ -3,6 +3,18 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.11.5](https://github.com/ciceksepetitech/cactus-ui/compare/@ciceksepeti/cui-dialog@0.11.1...@ciceksepeti/cui-dialog@0.11.5) (2024-02-13)
+
+
+
+## 0.0.26 (2024-02-12)
+
+**Note:** Version bump only for package @ciceksepeti/cui-dialog
+
+
+
+
+
 ## [0.11.4](https://github.com/ciceksepetitech/cactus-ui/compare/@ciceksepeti/cui-dialog@0.11.1...@ciceksepeti/cui-dialog@0.11.4) (2024-02-12)
 
 **Note:** Version bump only for package @ciceksepeti/cui-dialog

diff --git a/packages/dialog/package.json b/packages/dialog/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ciceksepeti/cui-dialog",
-  "version": "0.11.4",
+  "version": "0.11.5",
   "description": "ÇiçekSepeti Accessible Dialog Component",
   "author": "ciceksepeti",
   "main": "dist/src/index.js",
@@ -24,11 +24,11 @@
     "url": "git+https://github.com/ciceksepetitech/cactus-ui.git"
   },
   "dependencies": {
-    "@ciceksepeti/cui-focus-trap": "0.1.4",
-    "@ciceksepeti/cui-hooks": "0.11.4",
-    "@ciceksepeti/cui-portal": "0.1.4",
-    "@ciceksepeti/cui-utils": "0.11.4",
-    "@ciceksepeti/cui-visually-hidden": "0.1.4",
+    "@ciceksepeti/cui-focus-trap": "0.1.5",
+    "@ciceksepeti/cui-hooks": "0.11.5",
+    "@ciceksepeti/cui-portal": "0.1.5",
+    "@ciceksepeti/cui-utils": "0.11.5",
+    "@ciceksepeti/cui-visually-hidden": "0.1.5",
     "react-remove-scroll": "^2.4.3"
   },
   "peerDependencies": {

diff --git a/packages/focus-trap/CHANGELOG.md b/packages/focus-trap/CHANGELOG.md
@@ -3,6 +3,18 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.1.5](https://github.com/ciceksepetitech/cactus-ui/compare/@ciceksepeti/cui-focus-trap@0.1.1...@ciceksepeti/cui-focus-trap@0.1.5) (2024-02-13)
+
+
+
+## 0.0.26 (2024-02-12)
+
+**Note:** Version bump only for package @ciceksepeti/cui-focus-trap
+
+
+
+
+
 ## [0.1.4](https://github.com/ciceksepetitech/cactus-ui/compare/@ciceksepeti/cui-focus-trap@0.1.1...@ciceksepeti/cui-focus-trap@0.1.4) (2024-02-12)
 
 **Note:** Version bump only for package @ciceksepeti/cui-focus-trap

diff --git a/packages/focus-trap/package.json b/packages/focus-trap/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ciceksepeti/cui-focus-trap",
-  "version": "0.1.4",
+  "version": "0.1.5",
   "description": "ÇiçekSepeti Focus Trap Component",
   "author": "ciceksepeti",
   "main": "dist/src/index.js",
@@ -20,8 +20,8 @@
     "url": "git+https://github.com/ciceksepetitech/cactus-ui.git"
   },
   "dependencies": {
-    "@ciceksepeti/cui-hooks": "0.11.4",
-    "@ciceksepeti/cui-utils": "0.11.4"
+    "@ciceksepeti/cui-hooks": "0.11.5",
+    "@ciceksepeti/cui-utils": "0.11.5"
   },
   "peerDependencies": {
     "react": ">=16",

diff --git a/packages/hooks/CHANGELOG.md b/packages/hooks/CHANGELOG.md
@@ -3,6 +3,18 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.11.5](https://github.com/ciceksepetitech/cactus-ui/compare/@ciceksepeti/cui-hooks@0.11.1...@ciceksepeti/cui-hooks@0.11.5) (2024-02-13)
+
+
+
+## 0.0.26 (2024-02-12)
+
+**Note:** Version bump only for package @ciceksepeti/cui-hooks
+
+
+
+
+
 ## [0.11.4](https://github.com/ciceksepetitech/cactus-ui/compare/@ciceksepeti/cui-hooks@0.11.1...@ciceksepeti/cui-hooks@0.11.4) (2024-02-12)
 
 **Note:** Version bump only for package @ciceksepeti/cui-hooks

diff --git a/packages/hooks/package.json b/packages/hooks/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@ciceksepeti/cui-hooks",
-  "version": "0.11.4",
+  "version": "0.11.5",
   "description": "ÇiçekSepeti Component Hooks",
   "author": "cs",
   "main": "dist/src/index.js",
@@ -15,7 +15,7 @@
     "README.md"
   ],
   "dependencies": {
-    "@ciceksepeti/cui-utils": "0.11.4"
+    "@ciceksepeti/cui-utils": "0.11.5"
   },
   "repository": {
     "type": "git",