Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump http-cache-semantics from 4.1.0 to 4.1.1 in /docs #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 4, 2023

Bumps http-cache-semantics from 4.1.0 to 4.1.1.

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1.
- [Release notes](https://github.com/kornelski/http-cache-semantics/releases)
- [Commits](kornelski/http-cache-semantics@v4.1.0...v4.1.1)

---
updated-dependencies:
- dependency-name: http-cache-semantics
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Feb 4, 2023
Copy link

@Missjones2 Missjones2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge

@@ -2135,9 +2135,9 @@
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge

grantmike pushed a commit to grantmike/evm-cctp-contracts that referenced this pull request Jan 23, 2025
…nd tests (circlefin#10)

As discussed offline with @walkerq, breaking apart STABLE-6895 into 2
parts:

1) Extract base token messenger behavior and tests, copied from v1, into
a separate type (`BaseTokenMessenger`). This base type handles adding /
removing remote token messengers, the local minter, and encodes the
local message transmitter / version. `TokenMessengerV2` derives from
this type and layers on the v2-specific, messaging-layer differences. I
think this is more flexible for a potential v3 and is a natural
separation of concerns, but definitely open to further discussion!

2) (Future) integrate hooks, the first V2-specific functionality, into
`TokenMessengerV2`.

Some misc callouts:
- Intention is leave the v1 contract code unmodified (optional: in the
future we can refactor `TokenMessenger.t.sol` to use these shared
baseTokenMessenger tests to avoid duplication).
- Added some additional Ownable2Step test cases into `TestUtils.sol`.
- Copied over the v1 unit tests from `TokenMessenger.t.sol`, but
injected more fuzzable inputs into some of the test cases.

Further callouts below in-line.
grantmike pushed a commit to grantmike/evm-cctp-contracts that referenced this pull request Jan 23, 2025
…nd tests (circlefin#10)

As discussed offline with @walkerq, breaking apart STABLE-6895 into 2
parts:

1) Extract base token messenger behavior and tests, copied from v1, into
a separate type (`BaseTokenMessenger`). This base type handles adding /
removing remote token messengers, the local minter, and encodes the
local message transmitter / version. `TokenMessengerV2` derives from
this type and layers on the v2-specific, messaging-layer differences. I
think this is more flexible for a potential v3 and is a natural
separation of concerns, but definitely open to further discussion!

2) (Future) integrate hooks, the first V2-specific functionality, into
`TokenMessengerV2`.

Some misc callouts:
- Intention is leave the v1 contract code unmodified (optional: in the
future we can refactor `TokenMessenger.t.sol` to use these shared
baseTokenMessenger tests to avoid duplication).
- Added some additional Ownable2Step test cases into `TestUtils.sol`. 
- Copied over the v1 unit tests from `TokenMessenger.t.sol`, but
injected more fuzzable inputs into some of the test cases.

Further callouts below in-line.
grantmike pushed a commit to grantmike/evm-cctp-contracts that referenced this pull request Jan 23, 2025
…nd tests (circlefin#10)

As discussed offline with @walkerq, breaking apart STABLE-6895 into 2
parts:

1) Extract base token messenger behavior and tests, copied from v1, into
a separate type (`BaseTokenMessenger`). This base type handles adding /
removing remote token messengers, the local minter, and encodes the
local message transmitter / version. `TokenMessengerV2` derives from
this type and layers on the v2-specific, messaging-layer differences. I
think this is more flexible for a potential v3 and is a natural
separation of concerns, but definitely open to further discussion!

2) (Future) integrate hooks, the first V2-specific functionality, into
`TokenMessengerV2`.

Some misc callouts:
- Intention is leave the v1 contract code unmodified (optional: in the
future we can refactor `TokenMessenger.t.sol` to use these shared
baseTokenMessenger tests to avoid duplication).
- Added some additional Ownable2Step test cases into `TestUtils.sol`. 
- Copied over the v1 unit tests from `TokenMessenger.t.sol`, but
injected more fuzzable inputs into some of the test cases.

Further callouts below in-line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant