Uncomment assertion #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsf9k
force-pushed
the
testing/uncomment-assertion
branch
from
76c3224
to
ca734a8
Compare
|
The checks should pass once #9 is merged and this branch is rebased on top of that. |
jsf9k
requested review from
dav3r,
felddy,
jasonodoom and
mcdonnnj
as code owners
mcdonnnj
approved these changes
Jun 25, 2024
This can be done now that pytest-dev/pytest-testinfra#767 has been merged and released in version 10.1.1: https://github.com/pytest-dev/pytest-testinfra/releases/tag/10.1.1 See also: - pytest-dev/pytest-testinfra#757 - pytest-dev/pytest-testinfra#767
jsf9k
force-pushed
the
testing/uncomment-assertion
branch
from
ca734a8
to
b780cad
Compare
6 tasks
dav3r
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request uncomments an assertion in test code.
💭 Motivation and context
Resolves #3.
The assertion was previously commented out because of pytest-dev/pytest-testinfra#757. This issue was remedied in pytest-dev/pytest-testinfra#767, and that pull request has been merged and released in version 10.1.1.
See also:
SystemdService.existsfails with an error due to a malformed command pytest-dev/pytest-testinfra#757🧪 Testing
All automated tests pass.
✅ Pre-approval checklist