You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The individual test_whois, test_https, etc get some testing, but when all_checks is run, all of the individual results are thrown together and passed through data_digest and handled identically at CDNid
To ensure that each scanner is working properly, they should be tested in isolation such that for example in our test case
that www.asu.edu is getting the expected results from specifically the cnames, headers, nameserver, whois queries, and these are producing the correct final output.
I believe that one of these modules could be not operating correctly, and we really would not know.
e.g. the WHOIS could be completely broken, but HTTPS scan finds the values we are looking for.
Also I noticed that in the few _all_checks tests that exist, the descriptions are incorrect and reference evaluating the IP address for a dns server.
Motivation and context
To ensure that the quality of data is consistent when reporting output from this tool.
Implementation notes
I believe that tests should both have mocked dns, whois, cname, https data and ensure that CDNid() produces valid results each time as expected for each input set.
Acceptance criteria
Test output clearly shows each source for CDNid processing is functioning properly
tests in test_detectCDN.py are correctly labeled/described
We use both real and synthetic data to ensure that changing environments don't totally break our test suite.
The text was updated successfully, but these errors were encountered:
S4lt5
changed the title
Better Test Granularity
Better Test Granularity for all_checks/CDNid
Oct 27, 2022
💡 Summary
The individual test_whois, test_https, etc get some testing, but when
all_checks
is run, all of the individual results are thrown together and passed throughdata_digest
and handled identically atCDNid
To ensure that each scanner is working properly, they should be tested in isolation such that for example in our test case
that www.asu.edu is getting the expected results from specifically the cnames, headers, nameserver, whois queries, and these are producing the correct final output.
I believe that one of these modules could be not operating correctly, and we really would not know.
e.g. the WHOIS could be completely broken, but HTTPS scan finds the values we are looking for.
Also I noticed that in the few _all_checks tests that exist, the descriptions are incorrect and reference evaluating the IP address for a dns server.
Motivation and context
To ensure that the quality of data is consistent when reporting output from this tool.
Implementation notes
I believe that tests should both have mocked dns, whois, cname, https data and ensure that CDNid() produces valid results each time as expected for each input set.
Acceptance criteria
The text was updated successfully, but these errors were encountered: