Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Test Granularity for all_checks/CDNid #49

Open
3 tasks
S4lt5 opened this issue Oct 27, 2022 · 0 comments
Open
3 tasks

Better Test Granularity for all_checks/CDNid #49

S4lt5 opened this issue Oct 27, 2022 · 0 comments

Comments

@S4lt5
Copy link

S4lt5 commented Oct 27, 2022

💡 Summary

The individual test_whois, test_https, etc get some testing, but when all_checks is run, all of the individual results are thrown together and passed through data_digest and handled identically at CDNid

To ensure that each scanner is working properly, they should be tested in isolation such that for example in our test case
that www.asu.edu is getting the expected results from specifically the cnames, headers, nameserver, whois queries, and these are producing the correct final output.

I believe that one of these modules could be not operating correctly, and we really would not know.

e.g. the WHOIS could be completely broken, but HTTPS scan finds the values we are looking for.

Also I noticed that in the few _all_checks tests that exist, the descriptions are incorrect and reference evaluating the IP address for a dns server.

Motivation and context

To ensure that the quality of data is consistent when reporting output from this tool.

Implementation notes

I believe that tests should both have mocked dns, whois, cname, https data and ensure that CDNid() produces valid results each time as expected for each input set.

Acceptance criteria

  • Test output clearly shows each source for CDNid processing is functioning properly
  • tests in test_detectCDN.py are correctly labeled/described
  • We use both real and synthetic data to ensure that changing environments don't totally break our test suite.
@S4lt5 S4lt5 changed the title Better Test Granularity Better Test Granularity for all_checks/CDNid Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant