Add the ability to configure input and output directories #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdonnnj
added
the
improvement
jsf9k
approved these changes
Mar 22, 2023
mcdonnnj
force-pushed
the
improvement/configure_output_directory
branch
from
f16190d
to
19cbe39
Compare
mcdonnnj
force-pushed
the
improvement/configure_output_directory
branch
from
19cbe39
to
0861aac
Compare
This allows configuring the output directory path for the vdp_scanner.py script. The default value for this argument is the previously hard-coded value to maintain expected functionality.
This allows configuring the input directory path for the vdp_scanner.py script. The default value for this argument is the previously hard- coded value to maintain expected functionality.
Add a HOST_MOUNT argument to the Dockerfile to support adjusting the path for the host mount directory in the image. Rearrange some of the RUN instructions in the Dockerfile and change the host mount directory creation to also create any intermediate directories.
mcdonnnj
force-pushed
the
improvement/configure_output_directory
branch
from
0861aac
to
fdb7eda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull requests adds the ability to configure the input and output directories used by the
vdp_scanner.pyscript. It also updates how the default directory is created in the Docker image configuration.💭 Motivation and context
Adding the ability to specify these directories is a useful feature but also makes it possible to more easily build on top of this image. As an example you may want to specify the sub-directory of the mounted Docker volume for output while leaving an input file in the root of that directory or even an entirely different mounted volume.
🧪 Testing
Automated testing passes. I verified locally that the new options work both in default and in customized configurations.
✅ Pre-approval checklist
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist