From 9ad358ca336ae0afd997a50519ac2f08b50d682d Mon Sep 17 00:00:00 2001
From: "Jurriaan H. Spaaks" <j.spaaks@esciencecenter.nl>
Date: Mon, 4 Sep 2023 15:43:17 +0200
Subject: [PATCH] debugging linting workflow

---
 .github/workflows/linting.yml | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml
index 33a612e2..2035a1ae 100644
--- a/.github/workflows/linting.yml
+++ b/.github/workflows/linting.yml
@@ -40,7 +40,14 @@ jobs:
         run: python3 -m pip install .[dev,gcloud,testing]
 
       - name: Check sorting of imports
-        run: isort --check-only --diff src/cffconvert test/
+        # isort returns zero even when there are problems, explicitly check there is no output 
+        run: |
+          output=$(isort --check-only --diff src/cffconvert test/)
+          if [[ -n "$output" ]]; then
+            exit 1
+          else
+            exit 0
+          fi
 
       - name: Run prospector
         run: prospector --profile-path .prospector.yml