testing order bug #344
Merged
testing order bug #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rfere with later calls; refs #343
…d restoring whatever had been configured before we got our grubby hands on it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way yaml text is parsed. It appears that ruamel.yaml persists some of its configuration, see
This PR stores the timestamp parser that is present before we change anything, and restores it afterwards. Additionally it configures the parser to read timestamps as timestamp under cff-version 1.0.x and 1.1.x and as string under cff-version 1.2.x and 1.3.x, but now using ruamel.yaml's own constructor methods from
YAML.SafeConstructor, as opposed to whatever it finds was previously configured as a parser.