Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chicago: Use title case for volume title #7344

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

adunning
Copy link
Contributor

@adunning adunning commented Dec 3, 2024

This ensures the correct capitalization of a volume title stored in sentence case, such as:

Knowles, David. The Religious Orders in England. Vol. 3, The Tudor Age. 3 vols. Cambridge: Cambridge University Press, 1959. https://doi.org/10.1017/CBO9780511560668.

I observe when testing with Zotero that, if the language is not set to English, the volume title is not set to sentence case as I would expect. I cannot however seem to find a way to control this in the CSL file: is this a bug in citeproc-js?

Copy link

github-actions bot commented Dec 3, 2024

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@bwiernik
Copy link
Member

bwiernik commented Dec 3, 2024

Casing is only applied to English titles. This is the expected behavior, as other languages have their own distinct casing rules and do not observe sentence/title casing conventions

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Dec 3, 2024
@adunning
Copy link
Contributor Author

adunning commented Dec 3, 2024

I am not seeing the expected behaviour you have described: with my proposed change, the volume title is being converted to title case even if the language is set to a non-English language code. Take this example:

Stotz, Peter. Handbuch zur lateinischen Sprache des Mittelalters. Vol. 1, Einleitung, Lexikologische Praxis, Wörter und Sachen, Lehnwortgut. 5 vols. Handbuch der Altertumswissenschaft, II.5. Munich: Beck, 2002.

Zotero is capitalizing 'und' with text-case="title" on volume-title, which must be a bug.

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Dec 3, 2024
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

14 styles changed, showing 10

chicago-annotated-bibliography.csl (modified style; unchanged output for sample items)
Hancké, Rhodes, and Thatcher, Beyond Varieties of Capitalism; “CSL Search by Example.”
Mares, “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?”; Fenner et al., “A Data Citation Roadmap for Scholarly Data Repositories.”

Citation Style Editor. “CSL Search by Example,” 2012. http://editor.citationstyles.org/searchByExample/.
Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, et al. “A Data Citation Roadmap for Scholarly Data Repositories.” Scientific Data 6, no. 1 (April 10, 2019): 28. https://doi.org/10.1038/s41597-019-0031-8.
Hancké, Bob, Martin Rhodes, and Mark Thatcher, eds. Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy. Oxford and New York: Oxford University Press, 2007.
Mares, Isabela. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?” In Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, , edited by Peter A. Hall and David Soskice, 184–213. New York: Oxford University Press, 2001.
chicago-author-date-16th-edition.csl (modified style; unchanged output for sample items)
(Hancké, Rhodes, and Thatcher 2007; “CSL Search by Example” 2012)
(Mares 2001; Fenner et al. 2019)

“CSL Search by Example.” 2012. Citation Style Editor. http://editor.citationstyles.org/searchByExample/.
Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, et al. 2019. “A Data Citation Roadmap for Scholarly Data Repositories.” Scientific Data 6 (1): 28. doi:10.1038/s41597-019-0031-8.
Hancké, Bob, Martin Rhodes, and Mark Thatcher, eds. 2007. Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy. Oxford and New York: Oxford University Press.
Mares, Isabela. 2001. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?” In Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, edited by Peter A. Hall and David Soskice, 184–213. New York: Oxford University Press.
chicago-author-date-basque.csl (modified style; unchanged output for sample items)
(Hancké et al. 2007; Ezez. 2012)
(Mares 2001; Fenner et al. 2019)

Ezez. 2012. «CSL search by example». Citation Style Editor. http://editor.citationstyles.org/searchByExample/.
Fenner, Martin et al. 2019. «A data citation roadmap for scholarly data repositories». Scientific Data 6 (1) (apirilak 10): 28. doi:10.1038/s41597-019-0031-8. http://www.nature.com/articles/s41597-019-0031-8.
Hancké, Bob et al. (arg.). 2007. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press.
Mares, Isabela. 2001. «Firms and the welfare state: When, why, and how does social policy matter to employers?» in ; Hall, Peter A. & Soskice, David (arg.). Varieties of capitalism. The institutional foundations of comparative advantage, 184–213. New York: Oxford University Press.
chicago-author-date-de.csl (modified style; unchanged output for sample items)
(Hancké, Rhodes und Thatcher 2007; O A 2012)
(Mares 2001; Fenner u. a. 2019)

Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, u. a. 2019. A data citation roadmap for scholarly data repositories. Scientific Data 6, Nr. 1 (10. April): 28. doi:10.1038/s41597-019-0031-8, http://www.nature.com/articles/s41597-019-0031-8 (zugegriffen: 27. April 2019).
Hancké, Bob, Martin Rhodes und Mark Thatcher, Hrsg. 2007. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press.
Mares, Isabela. 2001. Firms and the welfare state: When, why, and how does social policy matter to employers? In: Varieties of capitalism. The institutional foundations of comparative advantage, hg. von Peter A. Hall und David Soskice, 184–213. New York: Oxford University Press.
O A. 2012. CSL search by example. Citation Style Editor. http://editor.citationstyles.org/searchByExample/ (zugegriffen: 15. Dezember 2012).
chicago-author-date-fr.csl (modified style; unchanged output for sample items)
(Hancké, Rhodes, et Thatcher 2007; « CSL search by example » 2012)
(Mares 2001; Fenner et al. 2019)

« CSL search by example ». 2012. Citation Style Editor. 2012. http://editor.citationstyles.org/searchByExample/.
Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, et al. 2019. « A data citation roadmap for scholarly data repositories ». Scientific Data 6 (1) : 28. https://doi.org/10.1038/s41597-019-0031-8.
Hancké, Bob, Martin Rhodes, et Mark Thatcher, dir. 2007. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York : Oxford University Press.
Mares, Isabela. 2001. « Firms and the welfare state: When, why, and how does social policy matter to employers? » Dans Varieties of capitalism. The institutional foundations of comparative advantage. Sous la direction de Peter A. Hall et David Soskice, 184‑213. New York : Oxford University Press.
chicago-author-date-no-em-dash.csl (modified style; unchanged output for sample items)
(Hancké, Rhodes, and Thatcher 2007; “CSL Search by Example” 2012)
(Mares 2001; Fenner et al. 2019)

“CSL Search by Example.” 2012. Citation Style Editor. 2012. http://editor.citationstyles.org/searchByExample/.
Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, et al. 2019. “A Data Citation Roadmap for Scholarly Data Repositories.” Scientific Data 6 (1): 28. https://doi.org/10.1038/s41597-019-0031-8.
Hancké, Bob, Martin Rhodes, and Mark Thatcher, eds. 2007. Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy. Oxford and New York: Oxford University Press.
Mares, Isabela. 2001. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?” In Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, edited by Peter A. Hall and David Soskice, 184–213. New York: Oxford University Press.
chicago-author-date.csl (modified style; unchanged output for sample items)
(Hancké, Rhodes, and Thatcher 2007; “CSL Search by Example” 2012)
(Mares 2001; Fenner et al. 2019)

“CSL Search by Example.” 2012. Citation Style Editor. 2012. http://editor.citationstyles.org/searchByExample/.
Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, et al. 2019. “A Data Citation Roadmap for Scholarly Data Repositories.” Scientific Data 6 (1): 28. https://doi.org/10.1038/s41597-019-0031-8.
Hancké, Bob, Martin Rhodes, and Mark Thatcher, eds. 2007. Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy. Oxford and New York: Oxford University Press.
Mares, Isabela. 2001. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?” In Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, edited by Peter A. Hall and David Soskice, 184–213. New York: Oxford University Press.
chicago-fullnote-bibliography-no-em-dash.csl (modified style; unchanged output for sample items)
Bob Hancké, Martin Rhodes, and Mark Thatcher, eds., Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford and New York: Oxford University Press, 2007); “CSL Search by Example,” Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/.
Isabela Mares, “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?,” in Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, ed. Peter A. Hall and David Soskice (New York: Oxford University Press, 2001), 184–213; Martin Fenner et al., “A Data Citation Roadmap for Scholarly Data Repositories,” Scientific Data 6, no. 1 (April 10, 2019): 28, https://doi.org/10.1038/s41597-019-0031-8.

Citation Style Editor. “CSL Search by Example,” 2012. http://editor.citationstyles.org/searchByExample/.
Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, et al. “A Data Citation Roadmap for Scholarly Data Repositories.” Scientific Data 6, no. 1 (April 10, 2019): 28. https://doi.org/10.1038/s41597-019-0031-8.
Hancké, Bob, Martin Rhodes, and Mark Thatcher, eds. Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy. Oxford and New York: Oxford University Press, 2007.
Mares, Isabela. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?” In Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, , edited by Peter A. Hall and David Soskice, 184–213. New York: Oxford University Press, 2001.
chicago-fullnote-bibliography-short-title-subsequent.csl (modified style; unchanged output for sample items)
Bob Hancké, Martin Rhodes, and Mark Thatcher, eds., Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford and New York: Oxford University Press, 2007); “CSL Search by Example,” Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/.
Isabela Mares, “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?,” in Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, ed. Peter A. Hall and David Soskice (New York: Oxford University Press, 2001), 184–213; Martin Fenner et al., “A Data Citation Roadmap for Scholarly Data Repositories,” Scientific Data 6, no. 1 (April 10, 2019): 28, https://doi.org/10.1038/s41597-019-0031-8.

Citation Style Editor. “CSL Search by Example,” 2012. http://editor.citationstyles.org/searchByExample/.
Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, et al. “A Data Citation Roadmap for Scholarly Data Repositories.” Scientific Data 6, no. 1 (April 10, 2019): 28. https://doi.org/10.1038/s41597-019-0031-8.
Hancké, Bob, Martin Rhodes, and Mark Thatcher, eds. Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy. Oxford and New York: Oxford University Press, 2007.
Mares, Isabela. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?” In Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, , edited by Peter A. Hall and David Soskice, 184–213. New York: Oxford University Press, 2001.
chicago-fullnote-bibliography-with-ibid.csl (modified style; unchanged output for sample items)
Bob Hancké, Martin Rhodes, and Mark Thatcher, eds., Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy (Oxford and New York: Oxford University Press, 2007); “CSL Search by Example,” Citation Style Editor, 2012, http://editor.citationstyles.org/searchByExample/.
Isabela Mares, “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?,” in Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, ed. Peter A. Hall and David Soskice (New York: Oxford University Press, 2001), 184–213; Martin Fenner et al., “A Data Citation Roadmap for Scholarly Data Repositories,” Scientific Data 6, no. 1 (April 10, 2019): 28, https://doi.org/10.1038/s41597-019-0031-8.

Citation Style Editor. “CSL Search by Example,” 2012. http://editor.citationstyles.org/searchByExample/.
Fenner, Martin, Mercè Crosas, Jeffrey S. Grethe, David Kennedy, Henning Hermjakob, Phillippe Rocca-Serra, Gustavo Durand, et al. “A Data Citation Roadmap for Scholarly Data Repositories.” Scientific Data 6, no. 1 (April 10, 2019): 28. https://doi.org/10.1038/s41597-019-0031-8.
Hancké, Bob, Martin Rhodes, and Mark Thatcher, eds. Beyond Varieties of Capitalism: Conflict, Contradiction, and Complementarities in the European Economy. Oxford and New York: Oxford University Press, 2007.
Mares, Isabela. “Firms and the Welfare State: When, Why, and How Does Social Policy Matter to Employers?” In Varieties of Capitalism. The Institutional Foundations of Comparative Advantage, , edited by Peter A. Hall and David Soskice, 184–213. New York: Oxford University Press, 2001.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants