Update github action versions and change cr3 extract to build on master #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mddilley
approved these changes
Jul 14, 2023
mddilley
approved these changes
Jul 14, 2023
|
nice! |
| tags: atddocker/atd-vz-cr3-extract:${{ github.ref == 'refs/heads/production' && 'production' || 'latest' }} | ||
| tags: atddocker/atd-vz-cr3-extract:${{ github.ref == 'refs/heads/master' && 'production' || 'latest' }} |
There was a problem hiding this comment.
I had waffled on this back and forth heavily, before we had really started to get experience porting and adding DAGs. There's even a post it note on my monitor at home to ask y'all what you thought! I couldn't decide if we wanted to tie our images to release VZ Suite release events or if they should float to whenever we push changes on the main branch.
I am really glad you caught this. This is great, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated issues
none
The multi architecture image tagged production didn't build because it only builds when the production branch is updated. I changed the workflow to build the production tag when the code is merged to master for the cr3 narrative docker image but didn't touch the other two so Frank could give his input on whether or not those should wait for production releases.
Ship list