Extend the local stack script to pg_dump and restore the local DB #1280
Conversation
mddilley
requested review from
frankhereford,
patrickm02L,
chiaberry,
johnclary,
tillyw and
roseeichelmann
There was a problem hiding this comment.
This looks and works great Mike.
I have one question though: You've added support to dump the local DB into the dumps directory, and you've added support to specify the filename that you're going to use to replicate into from the live DB and to restore from. Is the intent that if you want to load a local dump file you have handy into your DB for you to copy it into the snapshots folder and then replicate-db with the -f arg pointing at it?
I guess put another way, is the intent to make it a manual operation to promote a local dump file into a snapshot that you can use by mving it from atd-vzd/dumps to atd-vzd/snapshots?
If so, that's totally cool, I'm just curious if I am getting the whole picture.
Thanks!! 🚢 🚢 🚢
| "remove-snapshots", | ||
| "hasura-console" | ||
| ], | ||
| ) | ||
| parser.add_argument("-f", "--filename", required=False) |
There was a problem hiding this comment.
At first, I was going to suggest something more specific that describes what the file needs to be, but then I realized that you can only use the -f flag meaningfully after the replicate-db command, so 👍.
There was a problem hiding this comment.
Cool - thanks for the sanity check 🙏
| if(args.filename): | ||
| snapshotFilename = args.filename | ||
| else: | ||
| today = date.today().strftime("%Y-%m-%d") | ||
| snapshotFilename = ( | ||
| "visionzero_" + today + "_" + ( | ||
| "with-change-log" if args.include_change_log_data else "without-change-log") + ".sql" | ||
| ) |
There was a problem hiding this comment.
I reallllly like that you can specify a filename to be used when pulling data down from the production machine.
|
@frankhereford Yeah, it does involve manually moving files between the |
|
@mddilley wrote:
I think it's great just the way it is. I just wanted to make sure I wasn't missing anything. This is top shelf stuff. |
Associated issues
This splits out the local tooling updates from #1274 so that we can get this merged into master sooner. It is intended to help out with the LDM local dev cycle.
Testing
URL to test:
Local
Steps to test:
./vision-zero replicate-db/atd-vzd/snapshots/with today's date./vision-zero dump-local-dbto pg_dump the local DB/atd-vzd/dumps/./vision-zero replicate-db -f <your data dump filename>.sqlto restore into the local DB. Totally open to suggestions on changing up the command arguments. 🙏 I just went with-fto get it working.Ship list