Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds e-scooter rider to vzv map #1283

Merged
merged 1 commit into from
Aug 31, 2023
Merged

adds e-scooter rider to vzv map #1283

merged 1 commit into from
Aug 31, 2023

Conversation

tillyw
Copy link
Contributor

@tillyw tillyw commented Aug 31, 2023 •
edited
Loading

Associated issues

fixes cityofaustin/atd-data-tech#12013

Testing

URL to test:
https://deploy-preview-1283--atd-vzv-staging.netlify.app/

Steps to test:

  • go to the vzv map, you should see a new mode category for 'E-Scooter Rider'
  • isolate that toggle and test it out under different categories and filters

Ship list

  • Code reviewed
  • Product manager approved

patrickm02L
patrickm02L approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@patrickm02L patrickm02L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

This is so cool! 🛴 🤳

Screen Shot 2023-08-31 at 3 34 22 PM

mddilley
mddilley approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@mddilley mddilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test steps work, and I like the new text key in the config! Thanks for getting this mode on the map too, and the numbers match up with what I'm seeing on the chart PR. 🚀

atd-vzv/src/views/nav/SideMapControl.js
@@ -413,7 +423,7 @@ const SideMapControl = ({ type }) => {
color={parameter.iconColor && parameter.iconColor}
/>
)}
{title}
{parameter.text ?? title}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

chiaberry
chiaberry approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@chiaberry chiaberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@tillyw
Copy link
Contributor Author

tillyw commented Aug 31, 2023

thanks, y'all! merging this one now :)

@tillyw tillyw merged commit 5e6a2cd into master Aug 31, 2023
10 checks passed
@tillyw tillyw deleted the 12013_add_e-scooter_to_vzv_map branch August 31, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickm02L patrickm02L patrickm02L approved these changes

@chiaberry chiaberry chiaberry approved these changes

@mddilley mddilley mddilley approved these changes

@johnclary johnclary Awaiting requested review from johnclary

@roseeichelmann roseeichelmann Awaiting requested review from roseeichelmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add e-scooter-rider to VZV map
4 participants
@tillyw @patrickm02L @chiaberry @mddilley