-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move CircleCI jobs to GH Actions #1289
Conversation
@@ -1,7 +1,7 @@ | |||
#!/usr/bin/env bash | |||
|
|||
# Determine work branch | |||
case "${CIRCLE_BRANCH}" in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CircleCI gave us this for free, but it is now exported in the Build step of the new workflow in this PR.
steps: | ||
- uses: actions/setup-python@v4 | ||
with: | ||
python-version: "3.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this bumps from 3.7 that was used in the CircleCI job. I think this is okay since it is what we used with the same tooling in the Moped workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! 🏗️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Associated issues
cityofaustin/atd-data-tech#11358
I adapted this from the existing CircleCI config and the Moped API workflow.
These changes:
atddocker/atd-vz-etl-agol
Docker image (definitely okay - see thread)atddocker/atd-vz-etl
Docker imageTesting
URL to test:
n/a
Steps to test:
Not sure beyond reading the code. This might take some tweaking by pushing to master or maybe there is a better way that I'm not thinking about?
Ship list
- [ ] Run migration steps in readme in /atd-vzd/ if needed