Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CircleCI jobs to GH Actions #1289

Merged
merged 5 commits into from
Sep 15, 2023
Merged

Conversation

mddilley
Copy link
Contributor

@mddilley mddilley commented Sep 11, 2023

Associated issues

cityofaustin/atd-data-tech#11358

I adapted this from the existing CircleCI config and the Moped API workflow.

These changes:

  • move the deployment of the VZ API from CircleCI to GH actions
  • stop building and pushing updates to the atddocker/atd-vz-etl-agol Docker image (definitely okay - see thread)
  • stop building and pushing updates to the atddocker/atd-vz-etl Docker image
    • we've moved all VZ ETLs to Airflow v2, and we update those images here
    • i think that means that this image is no longer used. The only results that come up when searching for these images in code are from outdated files in the atd-etl folder. We could spin off another cleanup issue for that. 🧹

Testing

URL to test:
n/a

Steps to test:
Not sure beyond reading the code. This might take some tweaking by pushing to master or maybe there is a better way that I'm not thinking about?


Ship list

  • Check that needed secrets are already in this repo's GH Action secrets
  • Remove unneeded secrets from rotation documentation
    - [ ] Run migration steps in readme in /atd-vzd/ if needed
  • Code reviewed
  • Product manager approved

@mddilley mddilley added the WIP Work in progress label Sep 11, 2023
@@ -1,7 +1,7 @@
#!/usr/bin/env bash

# Determine work branch
case "${CIRCLE_BRANCH}" in
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CircleCI gave us this for free, but it is now exported in the Build step of the new workflow in this PR.

steps:
- uses: actions/setup-python@v4
with:
python-version: "3.8"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this bumps from 3.7 that was used in the CircleCI job. I think this is okay since it is what we used with the same tooling in the Moped workflow.

Copy link
Member

@patrickm02L patrickm02L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! 🏗️

Copy link
Member

@chiaberry chiaberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@mddilley mddilley merged commit 1bb6f68 into master Sep 15, 2023
10 of 11 checks passed
@mddilley mddilley deleted the md-11358-mv-circle-ci-to-gh-action branch September 15, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants