-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle smaller cr3 pdf page size #1529
Conversation
new_cr3_form = False | ||
break | ||
return new_cr3_form | ||
if rgb_pixel[0] > 5 or rgb_pixel[1] > 5 or rgb_pixel[2] > 5: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i was having trouble hitting pure black pixels in the smaller format, so i added this narrow tolerance of 0
to 5
.
i know there's been a lot of noise here: this is ready for review again—thank you! |
payload={ | ||
"records_processed": records_processed, | ||
}, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i added this so that the number of CSVs processed will be saved in the import log even if the PDF import fails. the records_processed
will look something like this:
{"pdfs": 0, "units": 82, "charges": 16, "crashes": 38, "persons": 85}
and the completed_at
value will be null, indicating that the import is not complete.
I started following the test steps, and got an error about not finding the docker image, and I checked and my image was created this time as |
ah yes—same here. i think i had both images laying around this time, but we do need to update that command if you're using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
After getting past my user errors, I got this error after updating my env file to remove the ", I was good to go |
Associated issues
Testing
URL to test: Local
Steps to test:
The problematic extract is available in the
dev
inbox in S3 👍Start your local stack. Use this modified version of the vision-zero helper
Run the CRIS import ETL:
./extracts/extract_2023_[...]/crash_diagrams
Ship list