WIP: POC fix for dev/core#5571. #416
Conversation
|
(Standard links)
|
It depends on the package. For HTML_QuickForm, yes. Upstream hasn't released in years.
These files (
As far as I can tell, there's nothing in core or universe that calls out to
I can see how it might feel awkward -- the name suggests a kind of central function. But I think I agree it's OK. When I dig around for references to this method, it really does seem like (1) it's not a substantive part of the inheritance hierarchy and (2) it's only got the one internal caller. However, I'm finding the change to be regressive elsewhere, i.e.
For the standalone profile page, it worked before the patch. But with the patch, checkboxes go MIA. Compare:
|
…alues This does the same as civicrm/civicrm-packages#416 but in Civi code rather than in packages. My take on it is that the original sin is that the quickform class for rendering radio options does not nest them in a div / allow us to add classes to that div and hence we are working around it by rendering the radio options individually in the template layer. If we fix that maybe we revert this - it is mostly a case of registering a class with more suitable markup in HTML_QuickForm::registerElementType()
|
I've added a variant of this here - https://github.com/civicrm/civicrm-core/pull/31705/files#diff-5a429c6ee446ea34fcc58e2cf1e84a8befea3239e8519ebe59b32d335761b836R87 it is probably a bit narrow in that it only works on ones with the options_in_line configured - but it not in packages - still thinking there is another soluttion tho |
Reference issue: https://lab.civicrm.org/dev/core/-/issues/5571
Other thoughts:
packages/repo. Is a PR here even a reasonable thing to do?packages/_ORIGINAL_/HTML/QuickForm/Renderer/ITStatic.phppackages/_ORIGINAL_/HTML/QuickForm/Renderer/ArraySmarty.phppackages/HTML/QuickForm/Renderer/ITStatic.php