This repository has been archived by the owner on Mar 28, 2018. It is now read-only.
Inject sinon sandbox in the current module before the QUnit module's setup()` method is invoked. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s `setup()` method is invoked. This allows the developer to initiate their stubs, mocks and spies in the setup method, safe in the knowledge that they will be automatically reset between each test.
|
To run the JsTestDriver tests:
You should add a test using setup/teardown to demonstrate that this works. |
Updated sinon git module to v1.6.0.
|
Any thoughts on this? |
|
👍 |
| activeSandbox = sinon.sandbox.create(sandboxConfig); | ||
|
|
||
| // Restore the native setTimeout method as it's used internally by QUnit. | ||
| if (sinon.config.useFakeTimers) { |
There was a problem hiding this comment.
This is going to cause unexpected behavior, because Sinon will not work as advertised...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the developer to initiate their stubs, mocks and spies in the setup method, safe in the knowledge that they will be automatically reset between each test.
I had trouble getting the jsTestDriver unit tests to work (and wasn't 100% sure what coverage I should be adding!)