Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for high value datasets #262

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

seitenbau-govdata
Copy link
Member

@seitenbau-govdata seitenbau-govdata commented Jan 19, 2024

This Pull request adds support for High Value Datasets as specified in https://semiceu.github.io/DCAT-AP/releases/2.2.0-hvd/

  • Add dcatap.applicableLegislation and dcatap.hvdCategory to dcat:Dataset
  • Add dcatap.applicableLegislation to dcat:Distribution

Note: Tests are currently failing until #263 is solved.

@seitenbau-govdata seitenbau-govdata force-pushed the add-hvds-to-profile branch 5 times, most recently from 52b092b to ccb5ab5 Compare January 23, 2024 14:55
@seitenbau-govdata seitenbau-govdata marked this pull request as ready for review January 23, 2024 15:02
@seitenbau-govdata
Copy link
Member Author

The Tests are now working properly.
Does anyone want to take a look at this PR? Otherwise we`ll merge it soon and create a new version.

@toothstone
Copy link

The Tests are now working properly. Does anyone want to take a look at this PR? Otherwise we`ll merge it soon and create a new version.

I don't have the resources to run the code, but at least from reading the diff I would approve of the changes. They fit my understanding of the DCAT spec and I would have implemented it the same way.

Looking forward to see this released!

@seitenbau-govdata seitenbau-govdata merged commit cb69fb4 into ckan:master Feb 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants