DCAT AP v3 profile #294
Merged
DCAT AP v3 profile #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to use Package.extras instead ckan/ckan#8288
Move from an inheritance approach to a more "composition" one,
separating properties handling in three kinds of methods:
* `_base()` methods with common properties to *all* versions
* `_vX()` methods with properties also applied to higher versions
* `_vX_only()` methods with properties only applied to the current
version
So for instance, the DCAT AP 3 profile calls the following methods in
order:
```
def graph_from_dataset(self, dataset_dict, dataset_ref):
# Call base method for common properties
self._graph_from_dataset_base(dataset_dict, dataset_ref)
# DCAT AP v2 properties also applied to higher versions
self._graph_from_dataset_v2(dataset_dict, dataset_ref)
# DCAT AP v2 scheming fields
self._graph_from_dataset_v2_scheming(dataset_dict, dataset_ref)
# DCAT AP v3 properties also applied to higher versions
self._graph_from_dataset_v3(dataset_dict, dataset_ref)
```
|
Anyone interested in trying the DCAT AP v3 profile, this is ready to give it a go |
Fix method call in dcat ap 3 profile, surfaced after switching the default profile. Add changelog and update docs.
|
Great work @amercader ! Are there any plans for DatasetSeries support? It seems one of the most exciting (and difficult?) features of DCAT-3! |
|
You nailed it at the "difficult" bit @Markus92 ! 😄 |
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
euro_dcat_ap_3profile with initial support for DCAT AP v3. It includes changes in thedcat:Datasetanddcat:Distributionproperties.The v3 changes are not big in themselves but the profile classes have been refactored to a more "composition" approach to make easier to extend them going forward. For each DCAT AP version there are three kinds of methods:
_base()methods with common properties to all versions_vX()methods with properties introduced in this version and also applied to higher versions_vX_only()methods with properties only applied to the current versionTested the serializations against the official SHACL shapes (we are ignoring the same violations described in https://github.com/ckan/ckanext-dcat/pull/291for now)