Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCAT AP v3 profile #294

Merged
merged 17 commits into from
Aug 30, 2024
Merged

DCAT AP v3 profile #294

merged 17 commits into from
Aug 30, 2024

Commits on Aug 22, 2024

  1. Configuration menu
    Copy the full SHA
    1dd88f8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    00603a4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c8f708a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d480313 View commit details
    Browse the repository at this point in the history
  5. Fix class bug in serializer

    amercader committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    c0b5007 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    526e74a View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. PackageExtra no longer available on CKAN>2.11

    Need to use Package.extras instead
    
    ckan/ckan#8288
    amercader committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    25ae659 View commit details
    Browse the repository at this point in the history
  2. Refactor profiles to make them easier to extend

    Move from an inheritance approach to a more "composition" one,
    separating properties handling in three kinds of methods:
    
    * `_base()` methods with common properties to *all* versions
    * `_vX()` methods with properties also applied to higher versions
    * `_vX_only()` methods with properties only applied to the current
      version
    
    So for instance, the DCAT AP 3 profile calls the following methods in
    order:
    
    ```
        def graph_from_dataset(self, dataset_dict, dataset_ref):
    
            # Call base method for common properties
            self._graph_from_dataset_base(dataset_dict, dataset_ref)
    
            # DCAT AP v2 properties also applied to higher versions
            self._graph_from_dataset_v2(dataset_dict, dataset_ref)
    
            # DCAT AP v2 scheming fields
            self._graph_from_dataset_v2_scheming(dataset_dict, dataset_ref)
    
            # DCAT AP v3 properties also applied to higher versions
            self._graph_from_dataset_v3(dataset_dict, dataset_ref)
    
    ```
    amercader committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    b8d89cd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f88c97b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cffbf09 View commit details
    Browse the repository at this point in the history
  5. Remove debug commands

    amercader committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    38c49a5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    685d5d5 View commit details
    Browse the repository at this point in the history
  7. Fix test

    amercader committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    c8b87f3 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Configuration menu
    Copy the full SHA
    6ceb79b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    167c80d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a77f32e View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Default to euro_dcat_ap_3 profile

    Fix method call in dcat ap 3 profile, surfaced after switching the
    default profile. Add changelog and update docs.
    amercader committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    4ae8795 View commit details
    Browse the repository at this point in the history