Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add has_version to default schema #306

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

hcvdwerf
Copy link
Contributor

Missing has_version in full default example schema

@amercader amercader changed the title feat: add had_version to default schema feat: add has_version to default schema Oct 1, 2024
@amercader
Copy link
Member

@hcvdwerf Add this to make the failures go away:

diff --git a/ckanext/dcat/schemas/dcat_ap_full.yaml b/ckanext/dcat/schemas/dcat_ap_full.yaml
index fc89c0a..eea83b2 100644
--- a/ckanext/dcat/schemas/dcat_ap_full.yaml
+++ b/ckanext/dcat/schemas/dcat_ap_full.yaml
@@ -314,6 +314,7 @@ resource_fields:
 - field_name: has_version
   label: Has version
   preset: multiple_text
+  validators: ignore_missing scheming_multiple_text
   help_inline: true
   help_text: This property refers to a related Dataset that is a version, edition, or adaptation of the described Dataset.

@hcvdwerf hcvdwerf force-pushed the add-has_version-to-default-schema branch from ddea18e to b8361d6 Compare October 3, 2024 12:43
@hcvdwerf
Copy link
Contributor Author

hcvdwerf commented Oct 3, 2024

@hcvdwerf Add this to make the failures go away:

diff --git a/ckanext/dcat/schemas/dcat_ap_full.yaml b/ckanext/dcat/schemas/dcat_ap_full.yaml
index fc89c0a..eea83b2 100644
--- a/ckanext/dcat/schemas/dcat_ap_full.yaml
+++ b/ckanext/dcat/schemas/dcat_ap_full.yaml
@@ -314,6 +314,7 @@ resource_fields:
 - field_name: has_version
   label: Has version
   preset: multiple_text
+  validators: ignore_missing scheming_multiple_text
   help_inline: true
   help_text: This property refers to a related Dataset that is a version, edition, or adaptation of the described Dataset.

@amercader Thanks for the comment. This fix resolves the issue with the failing unit tests.

@amercader amercader merged commit 8f0f883 into ckan:master Oct 3, 2024
4 checks passed
@hcvdwerf hcvdwerf deleted the add-has_version-to-default-schema branch October 3, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants