Preserve extra URL arguments #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should not be merged until someone can test with a GeoServer that supports CORS. |
The WFS and WMS parts of the extension add or don't things to the url as required. Often this means that only the endpoint is needed as the resource URL but sometimes some extra parameters are needed and these get removed. This commit prevents that from happening but is only well tested for cases where the resource proxy is in use.
|
PR 7 years old and with conflicts. Target file has a new name although in this case the proposed changes can be rescued, however as pointed out in the last comment, it might not be ready. (it is marked as WIP)
It is probably safe to close it |
|
the approach here is valid, i ran in this issue with a mapserver, which has a required parameter ?map={path}, which gets removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WFS and WMS parts of the extension add or don't things to the url as required. Often this means that only the endpoint is needed as the resource URL but sometimes some extra parameters are needed and these get removed. This commit prevents that from happening but is only well tested for cases where the resource proxy is in use.