Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #396] Use form_snippets/help_text.html in repeating_subfields.html #397

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

themowski
Copy link
Contributor

Overview

This PR addresses #396, using form_snippets/help_text.html instead of custom help_text code in form_snippets/repeating_subfields.html.

Changes

  • Switch mixed tab & space indentation to all-space indentation
  • Replace help_text code with snippet injection code from another form_snippet file to use help_text.html

…ml for consistency with other snippets; replace mixed tabs with spaces
</div>
{% endif %}
</div>
{%- snippet 'scheming/form_snippets/help_text.html', field=field -%}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the actual core of the change, as discussed in #396. The other changes are just the tab -> space conversion.

@wardi wardi merged commit 3af6056 into ckan:master Jan 23, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants