Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump provider to v8 #67

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Bump provider to v8 #67

wants to merge 4 commits into from

Conversation

Shr3ps
Copy link
Member

@Shr3ps Shr3ps commented Sep 6, 2023

Remove data resources signalfx_aws_services, signalfx_azure_services, signalfx_gcp_services as they were based on a no longer maintained lists in the signalfx-go library. Users may use empty list to specify "all services" instead or use strings to specify selected services.

Remove data resources signalfx_aws_services, signalfx_azure_services, signalfx_gcp_services as they were based on a no longer maintained lists in the signalfx-go library. Users may use empty list to specify "all services" instead or use strings to specify selected services.
Copy link
Member

@pdecat pdecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind to do the same for other cloud integrations?

cloud/azure/sfx/versions.tf Outdated Show resolved Hide resolved
cloud/azure/versions.tf Outdated Show resolved Hide resolved
Co-authored-by: Patrick Decat <patrick.decat@fr.clara.net>
@Shr3ps Shr3ps requested a review from pdecat October 24, 2023 15:02
@Shr3ps Shr3ps marked this pull request as draft November 8, 2023 16:18
@@ -12,21 +9,20 @@ resource "signalfx_azure_integration" "azure_integration" {
app_id = var.azure_sp_application_id
secret_key = var.azure_sp_application_token

services = setsubtract(local.azure_services, var.excluded_services)
services = setsubtract(var.services, var.excluded_services)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Poil
Copy link

Poil commented Feb 27, 2024

Perhaps we can put default value for services

	services = [
		"microsoft.analysisservices/servers",
		"microsoft.apimanagement/service",
		"microsoft.automation/automationaccounts",
		"microsoft.batch/batchaccounts",
		"microsoft.cache/redis",
		"microsoft.cdn/cdnwebapplicationfirewallpolicies",
		"microsoft.cdn/profiles",
		"microsoft.classiccompute/virtualmachines",
		"microsoft.cognitiveservices/accounts",
		"microsoft.compute/virtualmachines",
		"microsoft.compute/virtualmachinescalesets",
		"microsoft.compute/virtualmachinescalesets/virtualmachines",
		"microsoft.containerinstance/containergroups",
		"microsoft.containerregistry/registries",
		"microsoft.containerservice/managedclusters",
		"microsoft.customerinsights/hubs",
		"microsoft.datafactory",
		"microsoft.datafactory/datafactories",
		"microsoft.datafactory/factories",
		"microsoft.datalakeanalytics/accounts",
		"microsoft.datalakestore/accounts",
		"microsoft.dataprotection/backupvaults",
		"microsoft.dbformariadb/servers",
		"microsoft.dbformysql/flexibleservers",
		"microsoft.dbformysql/servers",
		"microsoft.dbforpostgresql/flexibleservers",
		"microsoft.dbforpostgresql/servers",
		"microsoft.devices",
		"microsoft.devices/elasticpools",
		"microsoft.devices/elasticpools/iothubtenants",
		"microsoft.devices/iothubs",
		"microsoft.devices/provisioningservices",
		"microsoft.documentdb/databaseaccounts",
		"microsoft.eventgrid/domains",
		"microsoft.eventgrid/eventsubscriptions",
		"microsoft.eventgrid/extensiontopics",
		"microsoft.eventgrid/systemtopics",
		"microsoft.eventgrid/topics",
		"microsoft.eventhub/namespaces",
		"microsoft.hdinsight/clusters",
		"microsoft.insights/autoscalesettings",
		"microsoft.keyvault/vaults",
		"microsoft.kusto/clusters",
		"microsoft.locationbasedservices/accounts",
		"microsoft.logic/workflows",
		"microsoft.machinelearningservices/workspaces",
		"microsoft.maps/accounts",
		"microsoft.network/applicationgateways",
		"microsoft.network/azurefirewalls",
		"microsoft.network/dnszones",
		"microsoft.network/expressroutecircuits",
		"microsoft.network/frontdoors",
		"microsoft.network/loadbalancers",
		"microsoft.network/networkinterfaces",
		"microsoft.network/publicipaddresses",
		"microsoft.network/trafficmanagerprofiles",
		"microsoft.network/virtualnetworkgateways",
		"microsoft.notificationhubs/namespaces/notificationhubs",
		"microsoft.powerbidedicated/capacities",
		"microsoft.recoveryservices/vaults",
		"microsoft.relay/namespaces",
		"microsoft.search/searchservices",
		"microsoft.servicebus/namespaces",
		"microsoft.signalrservice/signalr",
		"microsoft.signalrservice/webpubsub",
		"microsoft.sql/managedinstances",
		"microsoft.sql/servers",
		"microsoft.sql/servers/databases",
		"microsoft.sql/servers/elasticpools",
		"microsoft.storage/storageaccounts",
		"microsoft.storage/storageaccounts/blobservices",
		"microsoft.storage/storageaccounts/fileservices",
		"microsoft.storage/storageaccounts/queueservices",
		"microsoft.storage/storageaccounts/tableservices",
		"microsoft.streamanalytics/streamingjobs",
		"microsoft.web",
		"microsoft.web/hostingenvironments/multirolepools",
		"microsoft.web/hostingenvironments/workerpools",
		"microsoft.web/serverfarms",
		"microsoft.web/sites",
		"microsoft.web/sites/slots"
	]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants