-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump provider to v8 #67
Draft
Shr3ps
wants to merge
4
commits into
master
Choose a base branch
from
bump_sfx_provider_azure
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shr3ps
requested review from
BzSpi,
cvauvarin,
JMHAUTBOIS-Claranet,
pdecat and
tchernomax
as code owners
September 6, 2023 09:10
Remove data resources signalfx_aws_services, signalfx_azure_services, signalfx_gcp_services as they were based on a no longer maintained lists in the signalfx-go library. Users may use empty list to specify "all services" instead or use strings to specify selected services.
Shr3ps
force-pushed
the
bump_sfx_provider_azure
branch
from
September 6, 2023 09:14
b11398b
to
691a192
Compare
pdecat
reviewed
Sep 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind to do the same for other cloud integrations?
pdecat
reviewed
Oct 24, 2023
Co-authored-by: Patrick Decat <patrick.decat@fr.clara.net>
Shr3ps
commented
Nov 8, 2023
@@ -12,21 +9,20 @@ resource "signalfx_azure_integration" "azure_integration" { | |||
app_id = var.azure_sp_application_id | |||
secret_key = var.azure_sp_application_token | |||
|
|||
services = setsubtract(local.azure_services, var.excluded_services) | |||
services = setsubtract(var.services, var.excluded_services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we can put default value for services
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove data resources signalfx_aws_services, signalfx_azure_services, signalfx_gcp_services as they were based on a no longer maintained lists in the signalfx-go library. Users may use empty list to specify "all services" instead or use strings to specify selected services.