Skip to content

Commit

Permalink
Move "Work-around for GHC 9.4 bug in ExpWithClashCF"
Browse files Browse the repository at this point in the history
Moves the workaround added in c1ef28f
from Exp.hs to ExpWithGhcCF.hs

When I updated the CI image from 9.4.3 to 9.4.6 the ExpWithGhcCF test
started to fail on the 9.4.6 nightly test with
    Other error:
    panic! (the 'impossible' happened)
      GHC version 9.4.6:
    	refineFromInScope

I've done some testing and I've found:
Using ghc <= 9.4.4:
 The -fno-specialise workaround isn't need at all

Using ghc 9.4.5 and 9.4.6:
 It needs the -fno-specialise workaround in ExpWithGhcCF, not in Exp.
 Otherwise the ExpWithGhcCF test fails,
 not the ExpWithClashCF like mentioned in the original commit msg.
  • Loading branch information
leonschoorl committed Aug 28, 2023
1 parent 934f946 commit cfd7357
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 0 additions & 1 deletion tests/shouldwork/Numbers/Exp.hs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
{-# LANGUAGE PartialTypeSignatures #-}

{-# OPTIONS_GHC -Wno-partial-type-signatures #-}
{-# OPTIONS_GHC -fno-specialise #-} -- TODO: remove when https://gitlab.haskell.org/ghc/ghc/-/issues/23109#note_499130 is fixed

{-# OPTIONS_GHC -fplugin=GHC.TypeLits.Extra.Solver #-}
{-# OPTIONS_GHC -fplugin=GHC.TypeLits.Normalise #-}
Expand Down
1 change: 1 addition & 0 deletions tests/shouldwork/Numbers/ExpWithGhcCF.hs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{-# LANGUAGE CPP #-}
{-# OPTIONS_GHC -fno-specialise #-} -- TODO: remove when https://gitlab.haskell.org/ghc/ghc/-/issues/23109#note_499130 is fixed

module ExpWithGhcCF where
import Clash.Prelude
Expand Down

0 comments on commit cfd7357

Please sign in to comment.