Add hex and octal BitVector parsing per issue 1772 #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-mckenna
requested changes
Jun 16, 2023
|
Overall this is looking good! Given that the Haddock is also user documentation, I'd like to see more examples worked out. |
NadiaYvette
force-pushed
the
nadia.chambers/issue1772
branch
from
1dcf53e
to
5562a42
Compare
NadiaYvette
added a commit
to NadiaYvette/clash-compiler
that referenced
this pull request
Jul 30, 2023
NadiaYvette
added a commit
to NadiaYvette/clash-compiler
that referenced
this pull request
Jul 30, 2023
clash-lang#2505 (comment) Also adjusts comments/documentation so the precise strings are shown.
Automatically switching between hex, octal and binary based on the prefix, akin to how BinaryLiterals does it, may be a better option.
Copyright was added to BitVector.hs and some of the comments referred to functions they were based on where they should've referred to the functions themselves, and explained undefined mask digits either ambiguously or just incorrectly.
clash-lang#2505 (comment) Also adjusts comments/documentation so the precise strings are shown.
NadiaYvette
force-pushed
the
nadia.chambers/issue1772
branch
from
fed1136
to
2f0790a
Compare
alex-mckenna
approved these changes
Jul 30, 2023
There was a problem hiding this comment.
Thanks for coming back to this @NadiaYvette, I'd forgotten about this PR.
@martijnbastiaan I'm happy with this PR as it stands, can you make sure it makes it in time for 1.8?
martijnbastiaan
requested changes
Jul 30, 2023
changelog/2023-07-29T21_30_46-04_00_Add_hex_and_octal_BitVector_parsing
Outdated
Show resolved
Hide resolved
I'll grapple people away from the release button until this is merged |
martijnbastiaan
approved these changes
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically switching between hex, octal and binary based on the prefix, akin to how BinaryLiterals does it, may be a better option. The API functions added are hLit and oLit, by analogy with bLit.
Fixes: #1772
Still TODO: