Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hex and octal BitVector parsing per issue 1772 #2505

Merged
merged 6 commits into from
Aug 12, 2023
Merged

Add hex and octal BitVector parsing per issue 1772 #2505

merged 6 commits into from
Aug 12, 2023

Commits on Jul 30, 2023

  1. Add hex and octal BitVector parsing per issue 1772 

    Automatically switching between hex, octal and binary based on the
prefix, akin to how BinaryLiterals does it, may be a better option.
    @NadiaYvette
    NadiaYvette committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    11dcc5c View commit details
    Browse the repository at this point in the history

  2. Correct comments and add changelog entry. 

    Copyright was added to BitVector.hs and some of the comments referred
to functions they were based on where they should've referred to the
functions themselves, and explained undefined mask digits either
ambiguously or just incorrectly.
    @NadiaYvette
    NadiaYvette committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    63470ba View commit details
    Browse the repository at this point in the history

  3. Expose hLit and oLit from the Prelude 

    Responds to:
clash-lang#2505 (comment)
    @NadiaYvette
    NadiaYvette committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    aeae04d View commit details
    Browse the repository at this point in the history

  4. Add and fix up testcases for hLit/oLit don't cares 

    clash-lang#2505 (comment)
Also adjusts comments/documentation so the precise strings are shown.
    @NadiaYvette
    NadiaYvette committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    2f0790a View commit details
    Browse the repository at this point in the history

  5. Move changelog entry to subdir

    @NadiaYvette
    NadiaYvette committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    b8f2a1b View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. Apply suggestions from code review

    @martijnbastiaan
    martijnbastiaan authored Aug 12, 2023
    Configuration menu
    Copy the full SHA
    58f18ea View commit details
    Browse the repository at this point in the history