Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple PrimitiveGuard annotations #2562

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

leonschoorl
Copy link
Member

@leonschoorl leonschoorl commented Aug 16, 2023

Fixes #1436

Due to some refactoring of the error reporting this slightly changes some of the error messages:

import Clash.Prelude
topEntity = False
{-# ANN topEntity (defSyn "foo") #-}
{-# ANN topEntity (defSyn "bar") #-}

Now generates:

    Error processing 'Synthesize' annotations on Main.topEntity:
    A binder can't have more than one 'Synthesize' annotation.

Instead of:

    The following value has multiple 'Synthesize' annotations: topEntity

Still TODO:

  • Write a changelog entry (see changelog/README.md)
  • Check copyright notices are up to date in edited files

Copy link
Member

@martijnbastiaan martijnbastiaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool :). Tiny changes requested.

clash-ghc/src-ghc/Clash/GHC/LoadModules.hs Outdated Show resolved Hide resolved
clash-ghc/src-ghc/Clash/GHC/LoadModules.hs Show resolved Hide resolved
@leonschoorl leonschoorl merged commit a2c648e into master Aug 18, 2023
12 checks passed
@leonschoorl leonschoorl deleted the fix1436-multiple-primguards branch August 18, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple PrimitiveGuard annotations makes Clash yield no output HDL
2 participants