Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable mmap crash workaround more widely (copy #2566) #2567

Merged
merged 4 commits into from
Aug 26, 2023
Merged

Enable mmap crash workaround more widely (copy #2566) #2567

merged 4 commits into from
Aug 26, 2023

Commits on Aug 24, 2023

  1. Add flag to workaround GHC heisenbug on CI (#2444) 

    In very specific tests in GitLab CI we are affected by GHC bug #19421.
We can work around the issue by passing `-with-rtsopts=-xm20000000` when
compiling an affected binary. This is a stopgap measure until the real
bug is fixed.

We have seen the bug:
- In `clash-testsuite` in `clashLibTest`s
- In `ffi:example` in the `clash` binary itself
- In `prelude:doctests`, probably in the `doctests` binary itself,
  although this is not certain.

and then only in GHC 9.0.2, although the bug should be in other versions
of GHC as well.

This workaround was applied only to GHC 9.0.2 on CI and only to those
cases that were observed to go wrong, although as a consequence now the
`clash` binary is always built with the RTS option.

The `ffi:example` test should no longer be affected by the GHC bug, but
it is a fairly useless test in its current state as it does not fail
when there are issues, and the tested code is actually faulty. It is
disabled to be fixed later.
    @DigitalBrains1 @leonschoorl
    DigitalBrains1 authored and leonschoorl committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    bb261ae View commit details
    Browse the repository at this point in the history

  2. Workaround GHC heisenbug on GitHub CI as well (#2495) 

    PR #2444 added a workaround for GitLab CI, but it is also needed on the
GitHub CI we run for external contributions.
    @DigitalBrains1 @leonschoorl
    DigitalBrains1 authored and leonschoorl committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    3e71a43 View commit details
    Browse the repository at this point in the history

  3. Update docker/CI to use the latest GHC minor versions 

    (cherry picked from commit 60e98a8)

# Conflicts:
#	.ci/docker/build-and-publish-docker-image.sh
#	.ci/gitlab/benchmark.yml
#	.ci/gitlab/common.yml
#	.github/workflows/ci.yml
#	.gitlab-ci.yml
    @leonschoorl
    leonschoorl committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    67558a9 View commit details
    Browse the repository at this point in the history

  4. Enable workaround_ghc_mmap_crash for all jobs with GHC < 9.2.8 

    We're getting the mmap crash now very regularly on the gitlab runners

(cherry picked from commit 52d85d7)
    @leonschoorl
    leonschoorl committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    c26d3d0 View commit details
    Browse the repository at this point in the history