Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flake.nix to make GHC 9.6.6 and GHC 9.8.2 available #2810

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

diegodiv
Copy link

The goal of this PR is to make Clash's flake usable with newer versions of GHC - 9.6.2 has this notorious problem where it throws an error when you output VHDL/Verilog. I enabled support for 9.6.6 and 9.8.2 in flake.nix along with updating flake.lock.

Still TODO:

  • Write a changelog entry (see changelog/README.md)
  • Check copyright notices are up to date in edited files

nix/overlay-ghc96.nix Outdated Show resolved Hide resolved
@christiaanb christiaanb removed their request for review September 25, 2024 14:17
@diegodiv
Copy link
Author

I changed the default version to GHC 9.10 for different reasons:

  • It's the newest version and it is stable enough - and supported by Clash.
  • We encountered some issues on other projects with older versions of GHC, especially with the interaction between clash-cores and Cabal, and directly going for GHC 9.10 solves the issue without having to resort to modifications like this one.

@diegodiv diegodiv marked this pull request as ready for review October 15, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants