Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

170 modernize packaging #174

Merged
merged 3 commits into from
Oct 25, 2023
Merged

170 modernize packaging #174

merged 3 commits into from
Oct 25, 2023

Conversation

cleder
Copy link
Owner

@cleder cleder commented Oct 25, 2023

workerB

@watermelon-copilot-for-code-review

WatermelonAI Summary

The three commits in this PR tell us that the focus is on modernizing the packaging of the project. Commit 1 suggests the use of keyword arguments for improved readability and maintainability. Commit 2 indicates the implementation of per file ignores for flake8, a static code analysis tool, in order to improve the code quality. Commit 3 adds a codecov token, which suggests an emphasis on code coverage and testing. Overall, these changes aim to make the project's packaging more up-to-date and efficient.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
Click here to login to Slack
Click here to login to Notion
Click here to login to Linear
Click here to login to Asana
pygeoif is an open repo and Watermelon will serve it for free.
🍉🫶

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c60c834) 100.00% compared to head (c8420ff) 100.00%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #174   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         2244      2244           
=========================================
  Hits          2244      2244           
Files Coverage Δ
pygeoif/factories.py 100.00% <100.00%> (ø)
pygeoif/feature.py 100.00% <ø> (ø)
pygeoif/functions.py 100.00% <100.00%> (ø)
pygeoif/geometry.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@what-the-diff
Copy link

what-the-diff bot commented Oct 25, 2023

PR Summary

  • Added Environment Token for Code Coverage
    The update in the run-all-tests.yml file permits token-based authentication for our code coverage tool, which helps in assessing how much of our codebase is covered by our tests.

  • Improved GeoSpacial Data Handling
    Several files including factories.py, function.py, feature.py, geometry.py were updated to better handle geographical data. These modifications include:

    • In factories.py, a new pattern and flags in the wkt_regex variable were added to better interpret a commonly used data format in Geographic Information Systems. The orient function was also improved to clearly specify the data structure being returned.
    • In feature.py, certain function definitions were thoroughly revised for better readability and understanding.
    • In geometry.py, the function definitions were reworked for better processing of geometric datasets, and class methods in the Polygon class and GeometryCollection was updated.
  • Update to Ignoring Specific Files in Linting
    The tox.ini file was updated to specifically ignore the pygeoif module and the types.py file when checking the codebase for style errors. This makes our linting process faster and more targeted.

@ghost
Copy link

ghost commented Oct 25, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@cleder cleder merged commit 930f6bf into develop Oct 25, 2023
38 of 39 checks passed
@cleder cleder deleted the 170-modernize-packaging branch October 25, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant