Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

170 modernize packaging - requirements to toml #175

Merged
merged 5 commits into from
Oct 27, 2023

Conversation

cleder
Copy link
Owner

@cleder cleder commented Oct 27, 2023

workerB

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c8420ff) 100.00% compared to head (2032a19) 100.00%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #175   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         2244      2244           
=========================================
  Hits          2244      2244           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@what-the-diff
Copy link

what-the-diff bot commented Oct 27, 2023

PR Summary

  • Updates to Dependencies and Python Versions
    Our team pinpointed some necessary adjustments within our project's dependencies and the Python versions we're using, mainly in the 'run-all-tests.yml' workflow file. We have added a new dependency (typing_extensions) and modified the utilized Python version (3.10 to 3.11). Both these changes help keep our code up-to-date and efficient.

  • Adding Additional Dependencies
    For better flexibility and effectiveness in our data management, we've integrated additional dependencies such as typing, complexity, and linting within the 'Install dependencies' process.

  • Enhanced Linting Process
    To improve our code quality and readability, we've introduced the ruff command to our linting process. This new command will assist us in maintaining clean and efficient code.

  • Upgrade Python Version
    We've upgraded the Python version used in the 'Set up Python 3.12' step (3.9 to 3.12). The latest version brings enhanced features and improves the performance of our project.

  • Adjustments in Optional Dependencies
    We've updated 'pyproject.toml' to include complexity and linting in the 'project.optional-dependencies' section. These additions provide optional tools that can enhance and strengthen our project's capabilities.

  • Removal of Redundant File
    Removed the 'test-requirements.txt' file as it is not needed anymore. This helps us in maintaining a simplified and clean project structure.

@ghost
Copy link

ghost commented Oct 27, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@cleder cleder merged commit a889b39 into develop Oct 27, 2023
41 of 42 checks passed
@cleder cleder deleted the 170-modernize-packaging branch October 27, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant