-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geometries should be immutable and hashable #128 (Sourcery refactored) #178
Geometries should be immutable and hashable #128 (Sourcery refactored) #178
Conversation
PR Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 128-geometries-should-be-immutable-and-hashable #178 +/- ##
=================================================================================
Coverage 100.00% 100.00%
=================================================================================
Files 21 21
Lines 2314 2312 -2
=================================================================================
- Hits 2314 2312 -2
☔ View full report in Codecov by Sentry. |
300cdbc
to
2589d12
Compare
2589d12
to
731a29e
Compare
interiors: Tuple[LinearRing, ...] = () | ||
if holes: | ||
interiors = tuple(LinearRing(hole) for hole in holes) | ||
interiors = tuple(LinearRing(hole) for hole in holes) if holes else () |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function Polygon.__init__
refactored with the following changes:
- Move setting of default value for variable into
else
branch (introduce-default-else
) - Replace if statement with if expression (
assign-if-exp
)
Pull Request #177 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
128-geometries-should-be-immutable-and-hashable
branch, then run:Help us improve this pull request!