Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move_coordinates supports generators (Sourcery refactored) #189

Closed
wants to merge 3 commits into from

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Nov 12, 2023

Pull Request #188 refactored by Sourcery.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Incorporate changes via command line
    git fetch https://github.com/cleder/pygeoif pull/188/head
    git merge --ff-only FETCH_HEAD
    git push

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Help us improve this pull request!

WatermelonAI Summary

AI Summary deactivated by sourcery-ai[bot]

GitHub PRs

No results found in Jira Tickets :(

No results found in Confluence Docs :(

No results found in Slack Threads :(

No results found in Notion Pages :(

No results found in Linear Tickets :(

No results found in Asana Tasks :(

pygeoif is an open repo and Watermelon will serve it for free.
🍉🫶
Why not invite more people to your team?

@pep8speaks
Copy link

pep8speaks commented Nov 12, 2023

Hello @sourcery-ai[bot]! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-11-12 22:08:56 UTC

deepsource-autofix bot added a commit that referenced this pull request Nov 12, 2023
This commit fixes the style issues introduced in 16d7cf5 according to the output
from Black and isort.

Details: #189

WatermelonAI Summary

AI Summary deactivated by sourcery-ai[bot]

GitHub PRs

No results found in Jira Tickets :(

No results found in Confluence Docs :(

No results found in Slack Threads :(

No results found in Notion Pages :(

No results found in Linear Tickets :(

No results found in Asana Tasks :(

pygeoif is an open repo and Watermelon will serve it for free.
🍉🫶

Copy link

what-the-diff bot commented Nov 12, 2023

PR Summary

  • Improved Code Compatibility
    The development team added an import statement in pygeoif/functions.py, which means we now support more types of data without issues.
  • New Test Cases
    New tests have been added to confirm the proper functioning of the move_coordinates function, ensuring the end result is reliable and error-free.
  • Handling Data Generators
    A key improvement is the use of Generators in the move_coordinates function. This allows us to operate on very large datasets effectively and efficiently without running out of memory.
  • Testing of Data Generators
    A test has been added to ensure move_coordinates produces a Generator, guaranteeing its correct implementation.
  • Support for Different coordinate dimensions
    The final enhancement in this update includes test cases confirming that move_coordinates can handle coordinates of varying dimensions, expanding its usability across more diverse datasets.

WatermelonAI Summary

AI Summary deactivated by sourcery-ai[bot]

GitHub PRs

No results found in Jira Tickets :(

No results found in Confluence Docs :(

No results found in Slack Threads :(

No results found in Notion Pages :(

No results found in Linear Tickets :(

No results found in Asana Tasks :(

pygeoif is an open repo and Watermelon will serve it for free.
🍉🫶
Try us on any JetBrains IDE!

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff2e39c) 100.00% compared to head (3f58c5e) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #189   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         2412      2430   +18     
=========================================
+ Hits          2412      2430   +18     
Files Coverage Δ
pygeoif/functions.py 100.00% <100.00%> (ø)
tests/test_functions.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghost
Copy link

ghost commented Nov 12, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@sourcery-ai sourcery-ai bot closed this Nov 13, 2023
@sourcery-ai sourcery-ai bot deleted the sourcery/pull-188 branch November 13, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants