Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 1.2.0 #193

Merged
merged 52 commits into from
Nov 27, 2023
Merged

release 1.2.0 #193

merged 52 commits into from
Nov 27, 2023

Conversation

cleder
Copy link
Owner

@cleder cleder commented Nov 27, 2023

No description provided.

cleder and others added 30 commits October 27, 2023 18:47
…e-and-hashable

Geometries should be immutable and hashable #128
updates:
- [github.com/psf/black: 23.10.0 → 23.10.1](psf/black@23.10.0...23.10.1)
- [github.com/astral-sh/ruff-pre-commit: v0.1.1 → v0.1.3](astral-sh/ruff-pre-commit@v0.1.1...v0.1.3)
[pre-commit.ci] pre-commit autoupdate
cleder and others added 22 commits November 5, 2023 16:07
introduced force_2d for a subset of geometries #180
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.1.3 → v0.1.4](astral-sh/ruff-pre-commit@v0.1.3...v0.1.4)
- [github.com/python-jsonschema/check-jsonschema: 0.27.0 → 0.27.1](python-jsonschema/check-jsonschema@0.27.0...0.27.1)
[pre-commit.ci] pre-commit autoupdate
updates:
- [github.com/psf/black: 23.10.1 → 23.11.0](psf/black@23.10.1...23.11.0)
- [github.com/astral-sh/ruff-pre-commit: v0.1.4 → v0.1.5](astral-sh/ruff-pre-commit@v0.1.4...v0.1.5)
- [github.com/pre-commit/mirrors-mypy: v1.6.1 → v1.7.0](pre-commit/mirrors-mypy@v1.6.1...v1.7.0)
[pre-commit.ci] pre-commit autoupdate
updates:
- [github.com/hakancelikdev/unimport: 1.0.0 → 1.1.0](hakancelikdev/unimport@1.0.0...1.1.0)
- [github.com/astral-sh/ruff-pre-commit: v0.1.5 → v0.1.6](astral-sh/ruff-pre-commit@v0.1.5...v0.1.6)
[pre-commit.ci] pre-commit autoupdate
it cannot be guaranteed that objects which compare equal have the same hash value
updates:
- [github.com/pre-commit/mirrors-mypy: v1.7.0 → v1.7.1](pre-commit/mirrors-mypy@v1.7.0...v1.7.1)
- [github.com/python-jsonschema/check-jsonschema: 0.27.1 → 0.27.2](python-jsonschema/check-jsonschema@0.27.1...0.27.2)
[pre-commit.ci] pre-commit autoupdate

Watermelon AI Summary

This Pull Request aggregates changes aimed at releasing version 1.2.0, focusing on making geometries in the codebase immutable and hashable to ensure consistency and easier management of data, updating documentation and development tools, and applying code quality enhancements and bug fixes.

GitHub PRs

Click here to login to Jira
Click here to login to Confluence
Click here to login to Slack
Click here to login to Notion
Click here to login to Linear
Click here to login to Asana
pygeoif is an open repo and Watermelon will serve it for free.
🍉🫶
Why not invite more people to your team?

@ghost
Copy link

ghost commented Nov 27, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a6bde2d) 100.00% compared to head (11b9410) 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #193    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           21        21            
  Lines         2244      2369   +125     
  Branches         0       256   +256     
==========================================
+ Hits          2244      2369   +125     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Nov 27, 2023

PR Summary

  • Documentation and Project Files Overhaul
    Major changes have been implemented to improve organization. File types have been mostly switched from .txt to .rst for better readability. The README.rst file has been updated to provide more precise and comprehensive information. A new .readthedocs.yaml file has been added for Read the Docs integration while the .gitignore file has been updated to better manage unwanted files. Also, the LICENSE.txt file has been replaced with LICENSE.rst.

  • Enhancements to pygeoif Module
    We've added some new functions to the factories.py and functions.py files. In particular, the force_2d and force_3d functions in factories.py to change the dimensionality of geometric shapes as needed. Additionally, changes in feature.py updates the interface for geographic elements. In geometry.py, we've made attributes immutable, providing better data integrity and safety.

  • Focusing on Python 3.8
    To ensure consistency and proper performance, we've set Python 3.8 as the specific target for linting in pyproject.toml.

  • Test Your Code Better
    Numerous test cases have been added in test_factories.py, focusing on checking the correct functionality of force_2d and force_3d functions. These ensure that the conversion of 2D and 3D points, geometry collections, and non-geometry objects are functioning properly.

  • Typo and Formatting Fixes
    Many minute changes and corrections were implemented mainly to fix typos, statement formatting, and duplicate test cases. These changes spanned numerous files including test_factories.py, test_functions.py, and test_geometrycollection.py among others.

  • Removed Code Ignoring
    The tox.ini file was updated to no longer ignore the LIT002 code, improving the thoroughness of our code checks.

@cleder cleder merged commit fe831e5 into main Nov 27, 2023
58 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants