fix(repo): Use same react, react-dom peer semver (#4758)

clerk · Dec 11, 2024 · 66ad299 · 66ad299
1 parent 7ad473e
commit 66ad299
Show file tree

Hide file tree

Showing 12 changed files with 62 additions and 37 deletions.
diff --git a/.changeset/chatty-walls-search.md b/.changeset/chatty-walls-search.md
@@ -0,0 +1,13 @@
+---
+'@clerk/chrome-extension': patch
+'@clerk/tanstack-start': patch
+'@clerk/react-router': patch
+'@clerk/clerk-js': patch
+'@clerk/elements': patch
+'@clerk/nextjs': patch
+'@clerk/shared': patch
+'@clerk/clerk-react': patch
+'@clerk/remix': patch
+---
+
+Using the same peerDependencies semver for react and react-dom
diff --git a/packages/chrome-extension/package.json b/packages/chrome-extension/package.json
@@ -64,8 +64,8 @@
     "typescript": "catalog:repo"
   },
   "peerDependencies": {
-    "react": ">=18",
-    "react-dom": ">=18"
+    "react": "catalog:peer-react",
+    "react-dom": "catalog:peer-react"
   },
   "engines": {
     "node": ">=18.17.0"

diff --git a/packages/clerk-js/package.json b/packages/clerk-js/package.json
@@ -93,8 +93,8 @@
     "webpack-merge": "^5.9.0"
   },
   "peerDependencies": {
-    "react": ">=18",
-    "react-dom": ">=18"
+    "react": "catalog:peer-react",
+    "react-dom": "catalog:peer-react"
   },
   "engines": {
     "node": ">=18.17.0"

diff --git a/packages/elements/package.json b/packages/elements/package.json
@@ -96,8 +96,8 @@
   },
   "peerDependencies": {
     "next": "^13.5.4 || ^14.0.3 || ^15",
-    "react": "^18.0.0 || ^19.0.0-beta",
-    "react-dom": "^18.0.0 || ^19.0.0-beta"
+    "react": "catalog:peer-react",
+    "react-dom": "catalog:peer-react"
   },
   "peerDependenciesMeta": {
     "next": {

diff --git a/packages/nextjs/package.json b/packages/nextjs/package.json
@@ -82,8 +82,8 @@
   },
   "peerDependencies": {
     "next": "^13.5.4 || ^14.0.3 || ^15.0.0",
-    "react": "^18 || ^19.0.0-0",
-    "react-dom": "^18 || ^19.0.0-0"
+    "react": "catalog:peer-react",
+    "react-dom": "catalog:peer-react"
   },
   "engines": {
     "node": ">=18.17.0"

diff --git a/packages/react-router/package.json b/packages/react-router/package.json
@@ -89,8 +89,8 @@
     "typescript": "catalog:repo"
   },
   "peerDependencies": {
-    "react": ">=18",
-    "react-dom": ">=18",
+    "react": "catalog:peer-react",
+    "react-dom": "catalog:peer-react",
     "react-router": "^7.0.2"
   },
   "engines": {

diff --git a/packages/react/package.json b/packages/react/package.json
@@ -89,8 +89,8 @@
     "typescript": "catalog:repo"
   },
   "peerDependencies": {
-    "react": "^18 || ^19.0.0-0",
-    "react-dom": "^18 || ^19.0.0-0"
+    "react": "catalog:peer-react",
+    "react-dom": "catalog:peer-react"
   },
   "engines": {
     "node": ">=18.17.0"

diff --git a/packages/remix/package.json b/packages/remix/package.json
@@ -93,8 +93,8 @@
   "peerDependencies": {
     "@remix-run/react": "^2.0.0",
     "@remix-run/server-runtime": "^2.0.0",
-    "react": ">=18",
-    "react-dom": ">=18",
+    "react": "catalog:peer-react",
+    "react-dom": "catalog:peer-react",
     "react-router": "^6.0.0"
   },
   "engines": {

diff --git a/packages/shared/package.json b/packages/shared/package.json
@@ -151,8 +151,8 @@
     "typescript": "catalog:repo"
   },
   "peerDependencies": {
-    "react": "^18 || ^19.0.0-0",
-    "react-dom": "^18 || ^19.0.0-0"
+    "react": "catalog:peer-react",
+    "react-dom": "catalog:peer-react"
   },
   "peerDependenciesMeta": {
     "react": {

diff --git a/packages/tanstack-start/package.json b/packages/tanstack-start/package.json
@@ -79,8 +79,8 @@
   "peerDependencies": {
     "@tanstack/react-router": ">=1.81.9",
     "@tanstack/start": ">=1.81.9",
-    "react": ">=18 || >=19.0.0-beta",
-    "react-dom": ">=18 || >=19.0.0-beta"
+    "react": "catalog:peer-react",
+    "react-dom": "catalog:peer-react"
   },
   "engines": {
     "node": ">=18.17.0"

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml
@@ -9,6 +9,11 @@ catalogs:
     '@types/react': 18.3.12
     '@types/react-dom': 18.3.1
 
+  # Can be referenced through "catalog:peer-react"
+  peer-react:
+    react: ^18.0.0 || ^19.0.0 || ^19.0.0-0
+    react-dom: ^18.0.0 || ^19.0.0 || ^19.0.0-0
+
   # Can be referenced through "catalog:repo"
   repo:
     tslib: 2.4.1