Use proper format values, and pass in body instead of query parmeter

clerk · Jan 13, 2025 · 9bd2134 · 9bd2134
1 parent 2e9888f
commit 9bd2134
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 5 deletions.
diff --git a/packages/backend/src/api/endpoints/SessionApi.ts b/packages/backend/src/api/endpoints/SessionApi.ts
@@ -22,7 +22,7 @@ type RefreshTokenParams = {
   request_originating_ip?: string;
   request_headers?: Record<string, string[]>;
   suffixed_cookies?: boolean;
-  format?: 'token' | 'cookies';
+  format?: 'token' | 'cookie';
 };
 
 export class SessionAPI extends AbstractAPI {
@@ -68,16 +68,16 @@ export class SessionAPI extends AbstractAPI {
   }
 
   public async refreshSession(sessionId: string, params: RefreshTokenParams & { format: 'token ' }): Promise<Token>;
-  public async refreshSession(sessionId: string, params: RefreshTokenParams & { format: 'cookies' }): Promise<Cookies>;
+  public async refreshSession(sessionId: string, params: RefreshTokenParams & { format: 'cookie' }): Promise<Cookies>;
   public async refreshSession(sessionId: string, params: RefreshTokenParams): Promise<Token>;
   public async refreshSession(sessionId: string, params: RefreshTokenParams): Promise<Token | Cookies> {
     this.requireId(sessionId);
-    const { format = 'token', suffixed_cookies, ...restParams } = params;
+    const { suffixed_cookies, ...restParams } = params;
     return this.request({
       method: 'POST',
       path: joinPaths(basePath, sessionId, 'refresh'),
       bodyParams: restParams,
-      queryParams: { format, suffixed_cookies },
+      queryParams: { suffixed_cookies },
     });
   }
 }
diff --git a/packages/backend/src/api/resources/Deserializer.ts b/packages/backend/src/api/resources/Deserializer.ts
@@ -1,6 +1,7 @@
 import {
   AllowlistIdentifier,
   Client,
+  Cookies,
   DeletedObject,
   Email,
   EmailAddress,
@@ -72,6 +73,8 @@ function jsonToObject(item: any): any {
       return AllowlistIdentifier.fromJSON(item);
     case ObjectType.Client:
       return Client.fromJSON(item);
+    case ObjectType.Cookies:
+      return Cookies.fromJSON(item);
     case ObjectType.EmailAddress:
       return EmailAddress.fromJSON(item);
     case ObjectType.Email:

diff --git a/packages/backend/src/api/resources/index.ts b/packages/backend/src/api/resources/index.ts
@@ -1,6 +1,7 @@
 export * from './AccountlessApplication';
 export * from './AllowlistIdentifier';
 export * from './Client';
+export * from './Cookies';
 export * from './DeletedObject';
 export * from './Email';
 export * from './EmailAddress';

diff --git a/packages/backend/src/tokens/request.ts b/packages/backend/src/tokens/request.ts
@@ -274,7 +274,7 @@ ${error.getFullMessage()}`,
     try {
       // Perform the actual token refresh.
       const response = await options.apiClient.sessions.refreshSession(decodeResult.payload.sid, {
-        format: 'cookies',
+        format: 'cookie',
         suffixed_cookies: authenticateContext.usesSuffixedCookies(),
         expired_token: expiredSessionToken || '',
         refresh_token: refreshToken || '',