fix(localizations): Force interpolation for socialButtonsBlockButtonManyInView
#4887
+20
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 6f7f46c The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
9 tasks
anagstef
reviewed
Jan 14, 2025
| @@ -547,7 +547,7 @@ export const beBY: LocalizationResource = { | |||
| }, | |||
| }, | |||
| socialButtonsBlockButton: 'Працягнуць з дапамогай {{provider|titleize}}', | |||
| socialButtonsBlockButtonManyInView: 'Увядзіце дадатковыя спосабы ўваходу', | |||
| socialButtonsBlockButtonManyInView: undefined, | |||
There was a problem hiding this comment.
@panteliselef Why don't we do the following for all localizations?
Suggested change
| socialButtonsBlockButtonManyInView: undefined, | |
| socialButtonsBlockButtonManyInView: '{{provider|titleize}}', |
There was a problem hiding this comment.
@anagstef if left undefined it will use the one defined in en-US right ?
There was a problem hiding this comment.
Yes, but there is a risk that someone will try to translate this wrong in the future again.
There was a problem hiding this comment.
i'm confused, but Typescript will not let them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR expands on the fix and issue mentioned in #4878
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change