You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous change changed the label for buttons when multiple SSO providers are active from the provider name to a long string, which breaks the layout. This change brings the label for the key socialButtonsBlockButtonManyInView back to the desired one and in line with other languages.
The previous value roughly translates to "Too many buttons are shown. Reduce amount of buttons to continue"—this doesn't make any sense and is unique to the German translations. The broken string was introduced in this commit, together with other changes, so it seems it fell through the cracks: b9a5bea#diff-96883e89b065cc0abf16578b55e5a53c76a77b62d3ea953fa4e6064c29da93aaR550
Without the fix, the SignIn component with German translations looks like this:
Checklist
pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
A previous change changed the label for buttons when multiple SSO providers are active from the provider name to a long string, which breaks the layout. This change brings the label for the key `socialButtonsBlockButtonManyInView` back to the desired one.
The broken string was introduced here: clerk@b9a5bea#diff-96883e89b065cc0abf16578b55e5a53c76a77b62d3ea953fa4e6064c29da93aaR550
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Hey @christiankaindl thanks for your contribution. This seems to be affecting more package so I opened #4887 to address that. Also the new PR will force the property to match a new pattern I order to avoid any similar issues in the future.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A previous change changed the label for buttons when multiple SSO providers are active from the provider name to a long string, which breaks the layout. This change brings the label for the key
socialButtonsBlockButtonManyInViewback to the desired one and in line with other languages.The previous value roughly translates to "Too many buttons are shown. Reduce amount of buttons to continue"—this doesn't make any sense and is unique to the German translations. The broken string was introduced in this commit, together with other changes, so it seems it fell through the cracks: b9a5bea#diff-96883e89b065cc0abf16578b55e5a53c76a77b62d3ea953fa4e6064c29da93aaR550
Without the fix, the SignIn component with German translations looks like this:
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change