-
Notifications
You must be signed in to change notification settings - Fork 0
/
00_srp.py
45 lines (27 loc) · 925 Bytes
/
00_srp.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
# QUESTION: Where is SRP being violated?
class Camera():
def connect(self, ip, port):
# connect camera
pass
def check_valid_ip_and_port(self, ip, port):
# check valid ip and port format
pass
def disconnect(self):
# disconnect camera
pass
def capture(self):
# capture image
pass
def save_image(self, img, path): #??
# save image to path
pass
def overlay_pcd_and_rgb(self, pcd, rgb):
# overlay pcd and rgb
pass
def convert_rgb_to_bgr(self, bgr):
# convert rgb to bgr
pass
### Notes (There are no right answers) ###
# check_valid_ip_and_port is doing two things
# overlay_pcd_and_rgb and convert_rgb_to_bgr are more suitable under another class / file as they pertain more to image processing
# save_image could also be in another class / file