move synaptic plasticity precise spike timing feature to nest#2035

clinssen · Aug 30, 2021 · fb9228d · fb9228d
1 parent 9c1cfa9
commit fb9228d
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/models/stdp_synapse.h b/models/stdp_synapse.h
@@ -217,7 +217,7 @@ inline void
 stdp_synapse< targetidentifierT >::send( Event& e, thread t, const CommonSynapseProperties& )
 {
   // synapse STDP depressing/facilitation dynamics
-  const double t_spike = e.get_stamp().get_ms() - e.get_offset();
+  const double t_spike = e.get_stamp().get_ms();
 
   // use accessor functions (inherited from Connection< >) to obtain delay and
   // target

diff --git a/nestkernel/connector_base_impl.h b/nestkernel/connector_base_impl.h
@@ -47,7 +47,6 @@ Connector< ConnectionT >::send_weight_event( const thread tid,
     wr_e.set_port( e.get_port() );
     wr_e.set_rport( e.get_rport() );
     wr_e.set_stamp( e.get_stamp() );
-    wr_e.set_offset( e.get_offset() );
     wr_e.set_sender( e.get_sender() );
     wr_e.set_sender_node_id( kernel().connection_manager.get_source_node_id( tid, syn_id_, lcid ) );
     wr_e.set_weight( e.get_weight() );

diff --git a/testsuite/pytests/test_stdp_synapse.py b/testsuite/pytests/test_stdp_synapse.py
@@ -339,9 +339,7 @@ def test_stdp_synapse(self):
         self.init_params()
         for self.dendritic_delay in [1., self.resolution]:
             self.init_params()
-            for self.nest_neuron_model in ["iaf_psc_exp",
-                                           "iaf_cond_exp",
-                                           "iaf_psc_exp_ps"]:
+            for self.nest_neuron_model in ["iaf_psc_exp", "iaf_cond_exp"]:
                 fname_snip = "_[nest_neuron_mdl=" + self.nest_neuron_model + "]"
                 self.do_nest_simulation_and_compare_to_reproduced_weight(fname_snip=fname_snip)