Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using vim buffers in the previews instead of cat or bat #42

Open
cljoly opened this issue Jun 4, 2022 · 0 comments
Open

Consider using vim buffers in the previews instead of cat or bat #42

cljoly opened this issue Jun 4, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@cljoly
Copy link
Owner

cljoly commented Jun 4, 2022

Need to check what the performance implications might be, but that would free us from an external dependency.
cljoly added a commit that referenced this issue Jun 4, 2022
@cljoly
fix: inconsistant return type when looking for a previewer
b7fb147 
`find_binary` was returning a string when it did not find a binary in
the table supplied, but a table when it found something. This caused
`table.insert` to error.

`find_binary` now always returns `nil` when it does not find a suitable
executable in the supplied list. This plays quite nicely with the
previews, as when the command supplied is `nil`, we don’t get any
preview. A better behavior might be to use a vim buffer as a previewer,
but that might have performance implications (#42).

Should fix #39 (at least the initial issue)
@cljoly cljoly added the enhancement New feature or request label Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cljoly