Python 3.12 #960
Merged
Python 3.12 #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeaky-pl
force-pushed
the
python-310
branch
from
4ae8c49
to
735d36a
Compare
squeaky-pl
force-pushed
the
python-312
branch
from
ae69146
to
7445dd1
Compare
squeaky-pl
force-pushed
the
python-310
branch
from
735d36a
to
927b60c
Compare
squeaky-pl
force-pushed
the
python-312
branch
from
7445dd1
to
bc8a283
Compare
squeaky-pl
commented
Oct 29, 2024
Dockerfile
Outdated
| python3-pip \ | ||
| libmysqlclient-dev \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| COPY /requirements/ /requirements/ | ||
| RUN python3.9 -m pip install pip==24.0 virtualenv==20.25.1 && \ |
There was a problem hiding this comment.
Python in Ubuntu 24.04 started complaining if you install packages into the operating system using pip, because you are supposed to install them using apt-get, and use virtualenv for everything else. I was doing that before because we had terribly outdated pip otherwise, but now we caught up with Python 3.12 so we can just use builtin venv from apt-get to create the virtualenv.
squeaky-pl
force-pushed
the
python-312
branch
from
bc8a283
to
c8ef921
Compare
squeaky-pl
force-pushed
the
python-312
branch
from
c8ef921
to
9ce7f7d
Compare
squeaky-pl
commented
Oct 30, 2024
| @@ -69,6 +69,7 @@ requests-file==1.5.1 | |||
| rollbar==0.16.2 | |||
| s3transfer==0.10.3 | |||
| setproctitle==1.2.2 | |||
| setuptools==75.2.0 | |||
There was a problem hiding this comment.
See: closeio/limitlion#37
drewler
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've already started testing this end to end on single pods where my email is synced, will of course do a canary.
Based on PR #959
TODO:
Full chain of PRs as of 2024-10-28
python-312➔python-310python-310➔master